Tryton - Issues

 

Issue7486

Title RFC: Asset subscribed
Priority feature Status testing
Superseder Simplify start/end date of subscription line usage
View: 7487
Nosy List ced, nicoe, reviewbot, vbastos
Type feature request Components
Assigned To ced Keywords review
Reviews 51361002
View: 51361002

Created on 2018-06-01.11:59:34 by nicoe, last changed by reviewbot.

Files
File name Uploaded Type Edit Remove
scenario_sale_subscription_asset.rst vbastos, 2018-06-05.12:07:53 text/plain
unnamed vbastos, 2018-06-05.12:07:52 text/plain
unnamed vbastos, 2018-06-11.07:52:12 text/plain
Messages
review51361002 updated at https://codereview.tryton.org/51361002/#ps160001
review51361002 updated at https://codereview.tryton.org/51361002/#ps120001
review51361002 updated at https://codereview.tryton.org/51361002/#ps100001
msg41326 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-06-11.08:34:07
Being reviewed by the community for inclusion.
msg41325 (view) Author: [hidden] (vbastos) Date: 2018-06-11.07:52:12
What's the next step for this module?

On Wed, Jun 6, 2018 at 4:56 PM, Review Robot <issue_tracker@tryton.org>
wrote:

>
> Review Robot <reviewbot@tryton.org> added the comment:
>
> review51361002 updated at https://codereview.tryton.org/51361002/#ps60001
>
> _______________________________________________
> Tryton issue tracker <issue_tracker@tryton.org>
> <https://bugs.tryton.org/issue7486>
> _______________________________________________
>
review51361002 updated at https://codereview.tryton.org/51361002/#ps60001
msg41235 (view) Author: [hidden] (vbastos) Date: 2018-06-05.12:07:53
On Tue, Jun 5, 2018 at 7:30 PM, Cédric Krier <issue_tracker@tryton.org>
wrote:

>
> Cédric Krier <cedric.krier@b2ck.com> added the comment:
>
> On 2018-06-05 10:31, Vincent wrote:
> > The only thing I was going to suggest is to extend the scenario test so
> that before you create an overlap, you transition the subscription back to
> a draft and add a line to a lot "003" that starts 1 or 2 days later.
> Obviously requires the creation of lot 003 first.
>
> What would be the goal of this addition?
>
>
I was just checking that it was working :) I wrote the test just in case
you want to include it.

Otherwise, I've been testing it and it LGTM.
msg41234 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-06-05.11:30:05
On 2018-06-05 10:31, Vincent wrote:
> The only thing I was going to suggest is to extend the scenario test so that before you create an overlap, you transition the subscription back to a draft and add a line to a lot "003" that starts 1 or 2 days later. Obviously requires the creation of lot 003 first.

What would be the goal of this addition?
msg41224 (view) Author: [hidden] (vbastos) Date: 2018-06-05.10:31:08
The only thing I was going to suggest is to extend the scenario test so that before you create an overlap, you transition the subscription back to a draft and add a line to a lot "003" that starts 1 or 2 days later. Obviously requires the creation of lot 003 first.
msg41223 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-06-05.08:55:06
On 2018-06-05 08:45, Vincent wrote:
> It's complex because if you are renting out similar products of different sizes for example you have to create 2 products of type service and 2 products of type asset.

It is for flexibility. The same asset could be rent with different
condition and services.
Also the accounting is different for a rental service than an asset so
we can not use an asset product to get the account for the rental
invoice.
msg41222 (view) Author: [hidden] (vbastos) Date: 2018-06-05.08:45:02
It's complex because if you are renting out similar products of different sizes for example you have to create 2 products of type service and 2 products of type asset.
msg41221 (view) Author: [hidden] (vbastos) Date: 2018-06-05.08:30:01
Ok, I went through the test scenario and I understand how it works now.
msg41220 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-06-05.08:05:42
No the rental business is a service. And this service may require the availability of an asset which is the purpose of this change.
msg41219 (view) Author: [hidden] (vbastos) Date: 2018-06-05.07:58:34
On the client side when you create a subscription it seems that it only lists products where type is service. Should we add this to the class SubscriptionService:

    product = fields.Many2One(
        'product.product', "Product", required=True,
        domain=[
            OR(('type', '=', 'service'),
             ('type', '=', 'service'))
            ])
review51361002 updated at https://codereview.tryton.org/51361002/#ps40001
review51361002 updated at https://codereview.tryton.org/51361002/#ps20001
msg41177 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-06-01.14:29:48
I think it requires issue7487
review51361002 updated at https://codereview.tryton.org/51361002/#ps1
msg41166 (view) Author: [hidden] (nicoe) (Tryton committer) (Tryton translator) Date: 2018-06-01.11:59:34
Following: https://discuss.tryton.org/t/asset-subscribed/566
History
Date User Action Args
2018-07-30 10:06:03reviewbotsetmessages: + msg42541
2018-07-26 08:33:52reviewbotsetmessages: + msg42369
2018-06-28 14:30:31reviewbotsetmessages: + msg41947
2018-06-11 08:34:07cedsetmessages: + msg41326
2018-06-11 07:52:13vbastossetfiles: + unnamed
messages: + msg41325
2018-06-06 08:56:53reviewbotsetmessages: + msg41261
2018-06-05 12:07:53vbastossetfiles: + unnamed, scenario_sale_subscription_asset.rst
messages: + msg41235
2018-06-05 11:30:06cedsetmessages: + msg41234
2018-06-05 10:31:09vbastossetmessages: + msg41224
2018-06-05 08:55:06cedsetmessages: + msg41223

Showing 10 items. Show all history (warning: this could be VERY long)