Tryton - Issues

 

Issue7323

Title Inactive records are shown once the show inactive records has been disabled
Priority bug Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type behavior Components sao
Assigned To ced Keywords review
Reviews 36191002
View: 36191002

Created on 2018-04-06.10:48:41 by pokoli, last changed by roundup-bot.

Messages
New changeset 620524b88ffb by C├ędric Krier in branch 'default':
Replace Model.find call in Screen.search_filter by direct call to search
http://hg.tryton.org/sao/rev/620524b88ffb
New review36191002 at https://codereview.tryton.org/36191002/#ps1
msg40201 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-04-17.18:55:24
Indeed the problem comes from Model.find which create a new Group with the context of the call. So this breaks all the rationalization of the context from issue7072.
So here is review36191002 which remove Model.find and directly call search like tryton does.
msg39836 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-04-06.10:48:41
Steps to reproduce:

1. Create a party and make it inactive.
2. Check the show inactive records button
3. Uncheck the show inactive records button

Expected behaviour:

- The inactive record is not shown

Current behaviour:

- The in active record is shown. 


This is due because the active_test keyword is keep on the context after disabling the show inactive records button.
History
Date User Action Args
2018-04-19 00:12:53roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg40244
2018-04-17 19:03:52reviewbotsetnosy: + reviewbot
messages: + msg40202
2018-04-17 19:03:51reviewbotsetreviews: 36191002
keyword: + review
2018-04-17 18:55:24cedsetstatus: in-progress -> testing
messages: + msg40201
2018-04-17 18:33:38cedsetstatus: unread -> in-progress
assignedto: ced
nosy: + ced
2018-04-06 10:48:41pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)