Tryton - Issues

 

Issue7248

Title ESC key used for Sao modals do not call response with RESPONSE_CANCEL
Priority bug Status resolved
Superseder Nosy List nicoe, reviewbot, roundup-bot
Type behavior Components sao
Assigned To nicoe Keywords review
Reviews 36041002
View: 36041002

Created on 2018-03-22.12:59:32 by nicoe, last changed by roundup-bot.

Messages
New changeset 0255038ffcb3 by Nicolas ?vrard in branch 'default':
Manually handle hiding of bootstrap Modals in forms and wizards
http://hg.tryton.org/sao/rev/0255038ffcb3
review36041002 updated at https://codereview.tryton.org/36041002/#ps80001
review36041002 updated at https://codereview.tryton.org/36041002/#ps60001
review36041002 updated at https://codereview.tryton.org/36041002/#ps40001
review36041002 updated at https://codereview.tryton.org/36041002/#ps20001
New review36041002 at https://codereview.tryton.org/36041002/#ps1
msg39209 (view) Author: [hidden] (nicoe) (Tryton committer) (Tryton translator) Date: 2018-03-22.12:59:31
I noticed that unlike the GTK client the bootstrap modals are simply dismissed when pressing the 'ESC' key in SAO whereas AFAIK they should call response('RESPONSE_CANCEL').
History
Date User Action Args
2018-03-24 20:31:01roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg39344
2018-03-24 12:55:21reviewbotsetmessages: + msg39317
2018-03-24 10:50:29reviewbotsetmessages: + msg39311
2018-03-23 21:16:35reviewbotsetmessages: + msg39289
2018-03-23 18:44:09reviewbotsetmessages: + msg39285
2018-03-22 13:16:51nicoesetstatus: in-progress -> testing
2018-03-22 13:14:20reviewbotsetnosy: + reviewbot
messages: + msg39210
2018-03-22 13:14:19reviewbotsetreviews: 36041002
keyword: + review
2018-03-22 12:59:32nicoecreate

Showing 10 items. Show all history (warning: this could be VERY long)