Tryton - Issues

 

Issue7238

Title Use description as field rec_name
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components trytond
Assigned To pokoli Keywords review
Reviews 40191002
View: 40191002

Created on 2018-03-20.11:30:23 by pokoli, last changed by roundup-bot.

Messages
New changeset c60a75a11bd1 by Sergi Almacellas Abellana in branch 'default':
Use field_description as field rec_name when available
http://hg.tryton.org/trytond/rev/c60a75a11bd1
review40191002 updated at https://codereview.tryton.org/40191002/#ps20001
msg39170 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-21.13:03:22
For party, we have the code to "uniquify".
I think adding the name in parenthesis is a good solution.
msg39111 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-03-20.12:25:48
> But the description is not guarantee to be unique.

But the rec_name is not guaranteed to be unique. For example, creating several parties with the same name will produce to non unique rec_names. 

Maybe we should combine the description and the field name. Something like: 

Description (name)

Thoughts?
msg39110 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-20.12:16:32
But the description is not guarantee to be unique.
review40191002 updated at https://codereview.tryton.org/40191002/#ps1
msg39106 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-03-20.11:30:23
For a better user experience is better to use the description as field rec_name because this field is what the users see as label on the forms and in the application. Furthermore this is translated while the internal name is not translated. 

This useful on the notification_email module to be able to properly identify the field used for recipients.
History
Date User Action Args
2018-03-22 11:06:27roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg39200
2018-03-21 14:14:45reviewbotsetmessages: + msg39173
2018-03-21 13:03:22cedsetmessages: + msg39170
2018-03-20 12:25:48pokolisetmessages: + msg39111
2018-03-20 12:16:32cedsetnosy: + ced
messages: + msg39110
2018-03-20 11:55:41reviewbotsetnosy: + reviewbot
messages: + msg39109
2018-03-20 11:31:28pokolisetstatus: in-progress -> testing
reviews: 40191002
keyword: + review
2018-03-20 11:30:23pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)