Tryton - Issues

 

Issue7223

Title Remove active on timesheet work
Priority feature Status chatting
Superseder Nosy List ced, edbo, reviewbot
Type behavior Components timesheet
Assigned To Keywords easy, review
Reviews 287851002
View: 287851002

Created on 2018-03-14.09:59:40 by ced, last changed by reviewbot.

Messages
review287851002 updated at https://codereview.tryton.org/287851002/#ps283861002
New review287851002 at https://codereview.tryton.org/287851002/#ps273721002
msg51018 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-01.17:10:57
It will be good to implement issue4879 but I do not think the states on the timesheet_lines should depend on the current date. It will always be allowed to fill timesheet at a valid date.
msg51015 (view) Author: [hidden] (edbo) Date: 2019-08-01.16:56:38
I'm hitting https://bugs.tryton.org/issue4879 with changing the state for the timesheet_lines field (http://hg.tryton.org/modules/timesheet/file/tip/work.py#l60). The state depends on the 'active'-field which is removed.

Now I want the field depends on 'timesheet_end_date' and added:

states={
    'readonly': Date() > Eval('timesheet_end_date', Date()),
    }

But I got the message "AssertionError: statement must be an integer or a float"
msg51011 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-01.15:31:20
I do not think as there will be no migration of the data into another field. So it is better to keep the information if users want to do something with it.
msg51008 (view) Author: [hidden] (edbo) Date: 2019-08-01.15:19:28
I want to pick up this one. Should I also add a table query to remove the active column?
msg38980 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-14.09:59:39
The field is duplicate with the start/end date which can lead to incoherent situation like inactivate the timesheet.work of a project.work (still active).
History
Date User Action Args
2019-08-02 20:42:24reviewbotsetmessages: + msg51036
2019-08-01 18:32:58reviewbotsetnosy: + reviewbot
messages: + msg51021
2019-08-01 18:32:57reviewbotsetreviews: 287851002
keyword: + review
2019-08-01 17:10:57cedsetmessages: + msg51018
2019-08-01 16:56:38edbosetmessages: + msg51015
2019-08-01 15:31:20cedsetmessages: + msg51011
2019-08-01 15:19:28edbosetstatus: unread -> chatting
nosy: + edbo
messages: + msg51008
2018-03-14 09:59:40cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)