Tryton - Issues

 

Issue7214

Title Does not disable button on modified record
Priority bug Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot, wuf31
Type behavior Components sao
Assigned To ced Keywords review
Reviews 38111002
View: 38111002

Created on 2018-03-11.15:31:18 by wuf31, last changed by roundup-bot.

Messages
New changeset 03fb4abac1d6 by Cédric Krier in branch '4.6':
Disable button if parent is changed and ensure states is boolean
http://hg.tryton.org/sao/rev/03fb4abac1d6

New changeset 82a297cbe36d by Cédric Krier in branch '4.4':
Disable button if parent is changed and ensure states is boolean
http://hg.tryton.org/sao/rev/82a297cbe36d

New changeset a1bf0d8cf62b by Cédric Krier in branch '4.2':
Disable button if parent is changed and ensure states is boolean
http://hg.tryton.org/sao/rev/a1bf0d8cf62b

New changeset 48a313317cb5 by Cédric Krier in branch '4.0':
Disable button if parent is changed and ensure states is boolean
http://hg.tryton.org/sao/rev/48a313317cb5

New changeset 3d6f7f14da05 by Cédric Krier in branch '3.8':
Disable button if parent is changed and ensure states is boolean
http://hg.tryton.org/sao/rev/3d6f7f14da05
New changeset f9fa34816ac3 by Cédric Krier in branch 'default':
Disable button if parent is changed and ensure states is boolean
http://hg.tryton.org/sao/rev/f9fa34816ac3
review38111002 updated at https://codereview.tryton.org/38111002/#ps20001
msg39576 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-30.20:16:16
Indeed msg38947 is not fully right. The button are disabled if the record has modified values.
Here is review38111002 which fix sao behavior.
msg38949 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-11.16:07:11
OK, so it is a bug of sao as it should not allow to click on button if the record is modified.
msg38948 (view) Author: [hidden] (wuf31) Date: 2018-03-11.15:56:42
Thanks for the reply.

FYI, it works on sao.
msg38947 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-11.15:39:50
It is on purpose, buttons on popup only works if no changes have been made on the record. You must use the relate if you want to manipulate the generated invoices.
msg38946 (view) Author: [hidden] (wuf31) Date: 2018-03-11.15:31:17
Steps to reproduce:
1. Create a purchase order
2. Set to Quote
3. Set to Confirm
4. Set to Processing
5. Go to Invoice Tab
6. Double click invoice to open the invoice window
7. Validate the Invoice

This will gray out the cancel, validate and post buttons.

But if we do it from the supplier invoice menu, then we can validate the invoice
History
Date User Action Args
2018-04-13 20:22:20roundup-botsetmessages: + msg39979
2018-04-04 23:08:59roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg39728
2018-03-30 20:44:05reviewbotsetnosy: + reviewbot
messages: + msg39577
2018-03-30 20:16:17cedsetstatus: chatting -> testing
reviews: 38111002
messages: + msg39576
keyword: + review
assignedto: ced
2018-03-13 10:14:01pokolisetnosy: + pokoli
2018-03-11 16:07:11cedsetcomponent: + sao, - tryton
type: behavior
messages: + msg38949
title: 4.6 Client, cannot validate invoice from purchase window -> Does not disable button on modified record
2018-03-11 15:56:42wuf31setstatus: invalid -> chatting
messages: + msg38948
2018-03-11 15:39:51cedsetstatus: unread -> invalid
nosy: + ced
messages: + msg38947
2018-03-11 15:31:18wuf31create

Showing 10 items. Show all history (warning: this could be VERY long)