Tryton - Issues

 

Issue7159

Title Price for negative quantity
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type behavior Components product_price_list, purchase
Assigned To ced Keywords review
Reviews 43161002,44041002
View: 43161002, 44041002

Created on 2018-02-22.11:57:03 by ced, last changed by roundup-bot.

Messages
New changeset 169a417bcbdb by Cédric Krier in branch 'default':
Compare quantity as absolute value and enforce positive quantities
http://hg.tryton.org/modules/purchase/rev/169a417bcbdb
New changeset aeb2fb1325ad by Cédric Krier in branch 'default':
Compare quantity as absolute value and enforce positive quantities
http://hg.tryton.org/modules/product_price_list/rev/aeb2fb1325ad
review44041002 updated at https://codereview.tryton.org/44041002/#ps1
review43161002 updated at https://codereview.tryton.org/43161002/#ps1
msg38560 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-22.12:01:30
Indeed the same applies to the purchase supplier prices.
msg38559 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-22.11:57:02
The computation compare the quantity using the greater operator but it does not work if the quantity is negative as it will always be greater than the first line. This is only if the quantity in the price list is always positive which is the expected.
History
Date User Action Args
2018-02-28 18:58:13roundup-botsetmessages: + msg38690
2018-02-28 18:57:43roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg38689
2018-02-22 12:24:20reviewbotsetmessages: + msg38564
2018-02-22 12:24:18reviewbotsetnosy: + reviewbot
messages: + msg38563
2018-02-22 12:02:04cedsetstatus: in-progress -> testing
reviews: 43161002 -> 43161002,44041002
2018-02-22 12:01:30cedsetcomponent: + purchase
messages: + msg38560
2018-02-22 12:01:08cedsetreviews: 43161002
keyword: + review
2018-02-22 11:57:03cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)