Tryton - Issues

 

Issue7137

Title Connection leak with PostgreSQL ThreadedConnectionPool
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type crash Components trytond
Assigned To ced Keywords review
Reviews 39181002
View: 39181002

Created on 2018-02-14.13:34:16 by ced, last changed by roundup-bot.

Messages
New changeset 1b7a79203daf by Cédric Krier in branch '4.6':
Ensure to put back the connection with a try/finally
http://hg.tryton.org/trytond/rev/1b7a79203daf

New changeset e29a8825249e by Cédric Krier in branch '4.4':
Ensure to put back the connection with a try/finally
http://hg.tryton.org/trytond/rev/e29a8825249e

New changeset 871064b6c772 by Cédric Krier in branch '4.2':
Ensure to put back the connection with a try/finally
http://hg.tryton.org/trytond/rev/871064b6c772

New changeset 9a8e0f3346f7 by Cédric Krier in branch '4.0':
Ensure to put back the connection with a try/finally
http://hg.tryton.org/trytond/rev/9a8e0f3346f7
New changeset 607cf6e87aa4 by Cédric Krier in branch 'default':
Ensure to put back the connection with a try/finally
http://hg.tryton.org/trytond/rev/607cf6e87aa4
review39181002 updated at https://codereview.tryton.org/39181002/#ps1
msg38369 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-14.13:34:15
The methods list and init on Database take a connection but do not ensure to always put it back with a try/finally. Normally the code should not fail on normal condition but not under load stress. This may lead to connection being kept in the pool and never reused.
We should always guarantee to put back the connection to the pool with a try/finally.
History
Date User Action Args
2018-02-25 01:10:21roundup-botsetmessages: + msg38603
2018-02-19 19:11:37roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg38478
2018-02-14 13:53:25reviewbotsetnosy: + reviewbot
messages: + msg38370
2018-02-14 13:35:49cedsetstatus: in-progress -> testing
reviews: 39181002
keyword: + review
2018-02-14 13:34:16cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)