Tryton - Issues

 

Issue7118

Title ModelSQL.delete call always Translation.delete_ids
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type performance Components trytond
Assigned To ced Keywords review
Reviews 37981003
View: 37981003

Created on 2018-02-06.13:25:12 by ced, last changed by roundup-bot.

Messages
New changeset 1bd2c12c2ada by C├ędric Krier in branch 'default':
Delete translations only when model has translatable field
http://hg.tryton.org/trytond/rev/1bd2c12c2ada
review37981003 updated at https://codereview.tryton.org/37981003/#ps1
msg38235 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-06.13:25:12
When deleting a records, trytond tries to delete the linked translations even if the model does not have any translatable fields. The method has a cost as it always makes search queries.
So it will be better to not make this call if there are no translatable fields.
I do not think there is any issue regarding if the model had previously (in older version) translatable fields because it should be the responsibility of the migration.
History
Date User Action Args
2018-02-11 15:00:05roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg38302
2018-02-06 13:58:14reviewbotsetnosy: + reviewbot
messages: + msg38237
2018-02-06 13:28:41cedsetstatus: in-progress -> testing
reviews: 37981003
keyword: + review
2018-02-06 13:25:12cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)