Tryton - Issues

 

Issue7105

Title PYSON value is removed
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type behavior Components sao, tryton
Assigned To ced Keywords review
Reviews 46311002,44881002
View: 46311002, 44881002

Created on 2018-01-31.20:02:50 by ced, last changed by roundup-bot.

Messages
New changeset d0ad2b40cff8 by Cédric Krier in branch 'default':
Make PYSON widget works for Object and Array
http://hg.tryton.org/sao/rev/d0ad2b40cff8
New changeset 5ad4ad92b224 by Cédric Krier in branch 'default':
PYSON widget does not modify the value because of different encoding
http://hg.tryton.org/tryton/rev/5ad4ad92b224
review44881002 updated at https://codereview.tryton.org/44881002/#ps1
review46311002 updated at https://codereview.tryton.org/46311002/#ps1
msg39647 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-04-02.00:59:50
Indeed there were few issues:

- eval of object failed because https://stackoverflow.com/questions/4010775/javascript-eval-and-object-evaluation
- toString did not work on Object nor Array because it is not a JSON

But also I found that it is not possible to ensure that both clients encode the same statement the same way (key order, spaces etc.). So the widget should not change the value if the object value is still the same.
msg39126 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-20.16:56:22
It even mark as invalid, valid PYSON statement.
msg38138 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-01-31.20:02:49
It seems that the pyson widget does not work properly on sao. When entering a valid statement, it is erased once the focus is out.
History
Date User Action Args
2018-04-03 16:44:27roundup-botsetmessages: + msg39677
2018-04-03 16:43:10roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg39676
2018-04-02 01:23:39reviewbotsetmessages: + msg39649
2018-04-02 01:23:35reviewbotsetnosy: + reviewbot
messages: + msg39648
2018-04-02 01:03:37cedsetreviews: 46311002,44881002
keyword: + review
2018-04-02 00:59:51cedsetstatus: in-progress -> testing
component: + tryton
messages: + msg39647
2018-04-01 21:36:29cedsetstatus: chatting -> in-progress
assignedto: ced
2018-03-20 16:56:22cedsetstatus: unread -> chatting
messages: + msg39126
2018-01-31 20:02:50cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)