Tryton - Issues

 

Issue7094

Title gtk client crashes with warning in wizards
Priority bug Status resolved
Superseder Nosy List ced, jeremy.mousset, pokoli, reviewbot, roundup-bot
Type crash Components tryton
Assigned To ced Keywords review
Reviews 44621002
View: 44621002

Created on 2018-01-29.18:28:55 by jeremy.mousset, last changed by roundup-bot.

Files
File name Uploaded Type Edit Remove
client_logs.txt jeremy.mousset, 2018-02-06.16:50:00 text/plain
server_logs.txt jeremy.mousset, 2018-02-06.16:50:15 text/plain
Messages
New changeset 77cbfd98810c by C├ędric Krier in branch 'default':
Ensure right exceptions are raised by RPCExecute callback
http://hg.tryton.org/tryton/rev/77cbfd98810c
review44621002 updated at https://codereview.tryton.org/44621002/#ps1
msg38254 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-06.19:05:28
It is partially linked to the patch of issue6907 which must be reverted but also to the process_exception calls inside process_exception.
review44621002 should fix all the cases of exception raised in wizard.
msg38249 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-06.17:47:43
Indeed I can reproduce it.
msg38243 (view) Author: [hidden] (jeremy.mousset) Date: 2018-02-06.16:50:15
see also server logs
msg38242 (view) Author: [hidden] (jeremy.mousset) Date: 2018-02-06.16:50:00
I just cloned, added a warning in transition_upgrade of  ir.module.activate_upgrade and got the crash.

But I may be doing something wrong.

client logs attached
msg38133 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-01-31.17:40:49
I've tested on latest trunk and on 4.6 version and I can not reproduce the error. 

Are you sure you are using the latest 4.6 version? 

Could you please attach the server and the client logs in verbose mode?
msg38109 (view) Author: [hidden] (jeremy.mousset) Date: 2018-01-29.18:28:55
I've tested this issue on a 4.6 , but I would suspect default branch is also affected

To reproduce: 

Add a user warning in, for example, the transition_upgrade method of the wizard ir.module.activate_upgrade .
When the warning appears, click on "Yes".
The GTK client crashes and I get the following in the client logs:



ERROR:tryton.common.common:Traceback (most recent call last):
  File "/home/jeremy/workspace_b2ck/tryton/tryton/common/common.py", line 1207, in process
    self.callback(return_)
  File "/home/jeremy/workspace_b2ck/tryton/tryton/gui/window/wizard.py", line 104, in callback
    if 'view' in result:
TypeError: argument of type 'NoneType' is not iterable

argument of type 'NoneType' is not iterable
DEBUG:tryton.rpc:[2]
INFO:tryton.rpc:wizard.ir.module.activate_upgrade.delete(8, {u'language_direction': u'ltr', u'groups': [1], u'language': u'fr_FR'})
DEBUG:tryton.rpc:None
ERROR:tryton.common.common:Traceback (most recent call last):
  File "/home/jeremy/workspace_b2ck/tryton/tryton/common/common.py", line 1207, in process
    self.callback(return_)
  File "/home/jeremy/workspace_b2ck/tryton/tryton/gui/window/wizard.py", line 378, in end_callback
    callback()
  File "/home/jeremy/workspace_b2ck/tryton/tryton/gui/window/wizard.py", line 125, in <lambda>
    self.end(lambda *a: execute_actions())
  File "/home/jeremy/workspace_b2ck/tryton/tryton/gui/window/wizard.py", line 115, in execute_actions
    for action in result.get('actions', []):
AttributeError: 'list' object has no attribute 'get'
History
Date User Action Args
2018-02-19 19:06:48roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg38473
2018-02-06 19:17:22reviewbotsetnosy: + reviewbot
messages: + msg38255
2018-02-06 19:05:29cedsetstatus: in-progress -> testing
reviews: 44621002
messages: + msg38254
keyword: + review
2018-02-06 17:47:43cedsetstatus: need-eg -> in-progress
assignedto: ced
messages: + msg38249
nosy: + ced
2018-02-06 16:50:16jeremy.moussetsetfiles: + server_logs.txt
messages: + msg38243
2018-02-06 16:50:01jeremy.moussetsetfiles: + client_logs.txt
messages: + msg38242
2018-01-31 17:40:49pokolisetstatus: unread -> need-eg
nosy: + pokoli
messages: + msg38133
2018-01-29 18:28:55jeremy.moussetcreate

Showing 10 items. Show all history (warning: this could be VERY long)