Tryton - Issues

 

Issue7083

Title Ensure to have always an idempotency key
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type feature request Components account_payment_stripe
Assigned To ced Keywords review
Reviews 43061002
View: 43061002

Created on 2018-01-24.12:14:37 by ced, last changed by roundup-bot.

Messages
New changeset 3c9739e741e2 by C├ędric Krier in branch 'default':
Ensure to have an idempotency key by default
http://hg.tryton.org/modules/account_payment_stripe/rev/3c9739e741e2
review43061002 updated at https://codereview.tryton.org/43061002/#ps60001
review43061002 updated at https://codereview.tryton.org/43061002/#ps20001
review43061002 updated at https://codereview.tryton.org/43061002/#ps1
msg37917 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-01-24.12:14:36
Currently, we use the stripe_checkout_id as idempotency key but it is not always filled if the payment does not follow a checkout process. Also the checkout id is used as an authentication method for the checkout process, so it is better to not share it even with Stripe.
I propose to have a specific field that is filled with UUID4 by default and to use only this one as idempotency key.
History
Date User Action Args
2018-02-14 00:30:18roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg38362
2018-01-25 13:33:46reviewbotsetmessages: + msg38058
2018-01-24 13:04:54reviewbotsetmessages: + msg37921
2018-01-24 12:32:11reviewbotsetnosy: + reviewbot
messages: + msg37919
2018-01-24 12:17:31cedsetstatus: in-progress -> testing
reviews: 43061002
keyword: + review
2018-01-24 12:14:37cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)