Tryton - Issues

 

Issue7021

Title Show origin of standalone invoice line
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components account_invoice_line_standalone
Assigned To ced Keywords review
Reviews 42961003, 44541002, 42971002
View: 42961003, 44541002, 42971002

Created on 2017-12-19.16:25:35 by ced, last changed by roundup-bot.

Messages
New changeset f4db203a1b9f by Cédric Krier in branch 'default':
Use product and sale record name for line
http://hg.tryton.org/modules/sale/rev/f4db203a1b9f
New changeset 247d785c5c5d by Cédric Krier in branch 'default':
Use product and purchase record name for line
http://hg.tryton.org/modules/purchase/rev/247d785c5c5d
New changeset dfe02591ec5b by Cédric Krier in branch 'default':
Show origin of line
http://hg.tryton.org/modules/account_invoice_line_standalone/rev/dfe02591ec5b
review42971002 updated at https://codereview.tryton.org/42971002/#ps40001
msg37390 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-12-20.15:24:39
Indeed I wanted a meaningfull rec_name for the lines, specially to be able to distinguish the diferent lines on the same purchase (which was not the case in the first proposal). After I second thought, i think the current proposed patch (product@purchase) is a good solution as it's a good compromise between meaningfulness and complexity. If somebody needs more detail, it can be easily customized.
review42971002 updated at https://codereview.tryton.org/42971002/#ps20001
review44541002 updated at https://codereview.tryton.org/44541002/#ps20001
msg37379 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-19.18:05:09
On 2017-12-19 17:42, Sergi Almacellas Abellana wrote:
> Indeed, if you want to show the purchase or the sale, probably a new
> field origin_document field should be added and keep the line rec_name
> as is.

I do not want to add thousand of columns.
msg37378 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-19.18:05:06
On 2017-12-19 17:41, Sergi Almacellas Abellana wrote:
> 
> Sergi Almacellas Abellana <sergi@koolpi.com> added the comment:
> 
> > I do not get the point to try to put all fields in the record name.
> 
> I do not think the purchase name can identify a purchase line. So more
> information is needed to distinguish the line from the others in the
> same purchase.

Why would you want that? What is the use case?
msg37376 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-12-19.17:42:29
Indeed, if you want to show the purchase or the sale, probably a new field origin_document field should be added and keep the line rec_name as is.
msg37375 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-12-19.17:41:29
> I do not get the point to try to put all fields in the record name.

I do not think the purchase name can identify a purchase line. So more information is needed to distinguish the line from the others in the same purchase.
msg37374 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-19.17:40:24
I do not get the point to try to put all fields in the record name.
msg37371 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-12-19.16:57:47
For me purchase and sale is not enought as rec_name for the lines. 

I will prefer to use something similar to stock moves [1]. Probably surrounded by the purchase/sale like name.

1u [product or description]@purchase

For non lines with type different than line, probably the best is to show the description@purchase


[1] http://hg.tryton.org/modules/stock/file/e548935cb214/move.py#l536
New review42971002 at https://codereview.tryton.org/42971002/#ps1
New review44541002 at https://codereview.tryton.org/44541002/#ps1
New review42961003 at https://codereview.tryton.org/42961003/#ps1
msg37365 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-19.16:25:35
To select the invoice line standalone, it is easier to have the origin.
History
Date User Action Args
2017-12-26 17:38:56roundup-botsetmessages: + msg37461
2017-12-26 17:38:23roundup-botsetmessages: + msg37460
2017-12-26 17:37:17roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg37459
2017-12-20 16:49:48reviewbotsetmessages: + msg37395
2017-12-20 15:24:39pokolisetmessages: + msg37390
2017-12-19 19:43:17reviewbotsetmessages: + msg37382
2017-12-19 19:43:11reviewbotsetmessages: + msg37381
2017-12-19 18:05:10cedsetmessages: + msg37379
2017-12-19 18:05:06cedsetmessages: + msg37378
2017-12-19 17:42:29pokolisetmessages: + msg37376

Showing 10 items. Show all history (warning: this could be VERY long)