Tryton - Issues

 

Issue6997

Title Fullsize dialog
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components sao, tryton
Assigned To ced Keywords review
Reviews 36881002,40851002
View: 36881002, 40851002

Created on 2017-12-09.19:44:43 by ced, last changed by roundup-bot.

Messages
New changeset 580caa736f37 by Cédric Krier in branch 'default':
Use 100% width and height for modal-lg
http://hg.tryton.org/sao/rev/580caa736f37
New changeset 4655eba14d71 by Cédric Krier in branch 'default':
Use the same size for dialog as the sensible parent
http://hg.tryton.org/tryton/rev/4655eba14d71
msg37260 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-12.10:58:15
Not related to this issue.
msg37259 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-12-12.10:55:13
Then we should allow the same behaviour on sao. Probably by using a padding.
msg37258 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-12.10:40:03
To allow changing tab.
msg37257 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-12-12.10:16:44
Why not using always 100% width like done one sao?

I tested the patch and on gtk client it's possible to change the tab when a dialog window (many2one of a form is opened for example) but not when opening a dialog from menu. 

On sao the behaviour is consitent between both actions. And that makes me think it's a better behaviour.
review36881002 updated at https://codereview.tryton.org/36881002/#ps20001
review36881002 updated at https://codereview.tryton.org/36881002/#ps1
review40851002 updated at https://codereview.tryton.org/40851002/#ps1
msg37189 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-09.19:44:42
For now, in tryton we display the dialog 10% smaller then the below dialog. So the new dialog may become quickly too small to work with.

The proposal is to keep the same size as the parent dialog. This way we keep the choice of the user.

For sao, the modal-lg could take all the width of the page to mimic the behaviour.
History
Date User Action Args
2017-12-26 17:30:30roundup-botsetmessages: + msg37453
2017-12-26 17:29:58roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg37452
2017-12-12 10:58:15cedsetmessages: + msg37260
2017-12-12 10:55:13pokolisetmessages: + msg37259
2017-12-12 10:40:03cedsetmessages: + msg37258
2017-12-12 10:16:44pokolisetnosy: + pokoli
messages: + msg37257
2017-12-10 10:17:12reviewbotsetmessages: + msg37194
2017-12-09 20:41:08reviewbotsetmessages: + msg37192
2017-12-09 20:41:03reviewbotsetnosy: + reviewbot
messages: + msg37191
2017-12-09 20:09:35cedsetstatus: in-progress -> testing
reviews: 36881002,40851002
keyword: + review

Showing 10 items. Show all history (warning: this could be VERY long)