Tryton - Issues

 

Issue6972

Title Allow to change the party associated to a document after the document lines have been filled
Priority feature Status resolved
Superseder Nosy List ced, nicoe, reviewbot, roundup-bot
Type feature request Components account_invoice, purchase, sale
Assigned To ced Keywords review
Reviews 38991002, 37891002, 39991002
View: 38991002, 37891002, 39991002

Created on 2017-11-27.18:48:05 by nicoe, last changed by roundup-bot.

Messages
New changeset f2dcd2bed44b by Cédric Krier in branch 'default':
Make currency editable even if lines have been filled
http://hg.tryton.org/modules/account_invoice/rev/f2dcd2bed44b
New changeset 3cddbbec2ff3 by Cédric Krier in branch 'default':
Add wizard to modify purchase header after filling lines
http://hg.tryton.org/modules/purchase/rev/3cddbbec2ff3
New changeset 3414b8d97403 by Cédric Krier in branch 'default':
Add wizard to modify sale header after filling lines
http://hg.tryton.org/modules/sale/rev/3414b8d97403
review38991002 updated at https://codereview.tryton.org/38991002/#ps110001
New review39991002 at https://codereview.tryton.org/39991002/#ps1
review37891002 updated at https://codereview.tryton.org/37891002/#ps1
msg37309 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-15.10:07:05
I do not think we need to add such wizard on invoice because there are only two fields that are readonly when lines are filled: type and currency.
For the currency, it is a legacy from when the price was computed on invoice. So I remove the readonly with review39991002
For the type, we have a domain on both menu entry so it makes no sense to allow to change it.
review38991002 updated at https://codereview.tryton.org/38991002/#ps90001
review38991002 updated at https://codereview.tryton.org/38991002/#ps70001
review38991002 updated at https://codereview.tryton.org/38991002/#ps30001
review42881002 updated at https://codereview.tryton.org/42881002/#ps20001
msg37088 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-11-28.13:01:18
The feature must be more about allowing to change any readonly fields because of lines being not empty. This way it is a more generic feature that will works also for price list, warehouse etc.
review38991002 updated at https://codereview.tryton.org/38991002/#ps20001
New review42881002 at https://codereview.tryton.org/42881002/#ps1
New review38991002 at https://codereview.tryton.org/38991002/#ps1
msg37069 (view) Author: [hidden] (nicoe) (Tryton committer) (Tryton translator) Date: 2017-11-27.18:48:04
Sometimes the user might want to change the party of a document even after the document lines has been filed (eg: he duplicates a sale then change the customer or he did not noticed that he made a typo).

We propose to add a wizard that will allow to change the party associated to the sale / purchase / invoice
History
Date User Action Args
2018-04-05 12:14:10cedlinkissue3270 superseder
2018-01-08 19:32:43roundup-botsetmessages: + msg37525
2018-01-08 19:32:00roundup-botsetmessages: + msg37524
2018-01-08 19:31:32roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg37523
2017-12-15 10:21:54reviewbotsetmessages: + msg37312
2017-12-15 10:21:50reviewbotsetmessages: + msg37311
2017-12-15 10:21:50reviewbotsetreviews: 38991002,37891002 -> 38991002, 37891002, 39991002
2017-12-15 10:21:44reviewbotsetmessages: + msg37310
2017-12-15 10:18:39cedsetcomponent: - sale_price_list
2017-12-15 10:07:37cedsetreviews: 38991002 -> 38991002,37891002

Showing 10 items. Show all history (warning: this could be VERY long)