Tryton - Issues

 

Issue6919

Title Add depends to Button
Priority feature Status in-progress
Superseder Nosy List ced, pokoli, reviewbot
Type feature request Components trytond
Assigned To pokoli Keywords review
Reviews 40811002
View: 40811002

Created on 2017-11-06.23:01:27 by ced, last changed by reviewbot.

Messages
review40811002 updated at https://codereview.tryton.org/40811002/#ps60001
review40811002 updated at https://codereview.tryton.org/40811002/#ps40001
review40811002 updated at https://codereview.tryton.org/40811002/#ps20001
msg36820 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-11-10.11:50:10
Indeed it's not required to implement issue6389. 

I uploaded a first draft on review40811002. 

I'm if it's really required to be explicit on button depends, as I see no case where the depends will be missing and the test should pass. So I'm thinking if it won't be better to compute the buttons dependencies on modelview.
msg36816 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-11-10.11:04:19
I think we should finish issue6389 first.
msg36749 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-11-06.23:01:27
When we set PYSON to button, we rely on having the depending field in the view but instead we should use a 'depends' attribute like for fields.
We could have the same test for missing depends.
History
Date User Action Args
2017-11-27 14:03:11reviewbotsetmessages: + msg37059
2017-11-27 13:33:30reviewbotsetmessages: + msg37058
2017-11-10 12:01:34reviewbotsetnosy: + reviewbot
messages: + msg36821
2017-11-10 11:50:10pokolisetstatus: chatting -> in-progress
reviews: 40811002
messages: + msg36820
keyword: + review
assignedto: pokoli
2017-11-10 11:04:19pokolisetstatus: unread -> chatting
nosy: + pokoli
messages: + msg36816
2017-11-06 23:01:27cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)