Tryton - Issues

 

Issue6919

Title Add depends to Button
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components trytond
Assigned To pokoli Keywords review
Reviews 40811002
View: 40811002

Created on 2017-11-06.23:01:27 by ced, last changed by roundup-bot.

Messages
New changeset 4153faf25a3e by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/web_user/rev/4153faf25a3e
New changeset 87bf4df3f136 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/stock_split/rev/87bf4df3f136
New changeset 01d342c19f3c by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/stock_package_shipping/rev/01d342c19f3c
New changeset 448bb66fdf64 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/stock_forecast/rev/448bb66fdf64
New changeset bfaf80a1d4e8 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/stock/rev/bfaf80a1d4e8
New changeset 6c9109a47b3c by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/sale_supply_drop_shipment/rev/6c9109a47b3c
New changeset 79e6c3964cb9 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/sale_subscription/rev/79e6c3964cb9
New changeset cb0f645a131b by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/sale_opportunity/rev/cb0f645a131b
New changeset e01f6bae01fc by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/sale_complaint/rev/e01f6bae01fc
New changeset 975d1ee4eb6c by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/sale/rev/975d1ee4eb6c
New changeset 9d9e3522ea97 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/purchase_requisition/rev/9d9e3522ea97
New changeset ca66542abf93 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/purchase_request/rev/ca66542abf93
New changeset 09417c6de8e4 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/purchase/rev/09417c6de8e4
New changeset 173c1a7301e4 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/project_invoice/rev/173c1a7301e4
New changeset 816f5a7b9258 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/production_work/rev/816f5a7b9258
New changeset 5c91db118d88 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/production_split/rev/5c91db118d88
New changeset 32cc81828f21 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/production/rev/32cc81828f21
New changeset ac369e103531 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/commission/rev/ac369e103531
New changeset 0226662967b5 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/account_stock_landed_cost/rev/0226662967b5
New changeset 2ad09697781d by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/account_statement/rev/2ad09697781d
New changeset a1b4aa244da0 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/account_payment_stripe/rev/a1b4aa244da0
New changeset ac9057b51cef by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/account_payment_sepa/rev/ac9057b51cef
New changeset 8013d4e76c06 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/account_payment/rev/8013d4e76c06
New changeset ca7524ac26e8 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/account_invoice_correction/rev/ca7524ac26e8
New changeset 80fbc1dacc95 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/account_invoice/rev/80fbc1dacc95
New changeset 03ebffaade91 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/account_deposit/rev/03ebffaade91
New changeset e4dbe15c9e83 by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/account_asset/rev/e4dbe15c9e83
New changeset 99324a88d56c by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/account/rev/99324a88d56c
New changeset 4206d6bbf68f by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/trytond/rev/4206d6bbf68f
review40811002 updated at https://codereview.tryton.org/40811002/#ps60001
review40811002 updated at https://codereview.tryton.org/40811002/#ps40001
review40811002 updated at https://codereview.tryton.org/40811002/#ps20001
msg36820 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-11-10.11:50:10
Indeed it's not required to implement issue6389. 

I uploaded a first draft on review40811002. 

I'm if it's really required to be explicit on button depends, as I see no case where the depends will be missing and the test should pass. So I'm thinking if it won't be better to compute the buttons dependencies on modelview.
msg36816 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-11-10.11:04:19
I think we should finish issue6389 first.
msg36749 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-11-06.23:01:27
When we set PYSON to button, we rely on having the depending field in the view but instead we should use a 'depends' attribute like for fields.
We could have the same test for missing depends.
History
Date User Action Args
2018-02-19 11:49:55roundup-botsetmessages: + msg38459
2018-02-19 11:49:49roundup-botsetmessages: + msg38458
2018-02-19 11:49:42roundup-botsetmessages: + msg38457
2018-02-19 11:49:32roundup-botsetmessages: + msg38456
2018-02-19 11:49:25roundup-botsetmessages: + msg38455
2018-02-19 11:49:21roundup-botsetmessages: + msg38454
2018-02-19 11:49:15roundup-botsetmessages: + msg38452
2018-02-19 11:49:09roundup-botsetmessages: + msg38451
2018-02-19 11:49:05roundup-botsetmessages: + msg38450
2018-02-19 11:49:01roundup-botsetmessages: + msg38449

Showing 10 items. Show all history (warning: this could be VERY long)