Tryton - Issues

 

Issue6860

Title Do not set description as product record name
Priority feature Status resolved
Superseder Nosy List ced, jan, pokoli, reviewbot, roundup-bot
Type feature request Components account_invoice, purchase, sale
Assigned To ced Keywords review
Reviews 43781002, 43781003, 39911002, 38971002, 40831002, 44441002
View: 43781002, 43781003, 39911002, 38971002, 40831002, 44441002

Created on 2017-10-17.09:36:11 by ced, last changed by roundup-bot.

Files
File name Uploaded Type Edit Remove
jgras.vcf jan, 2017-10-17.15:39:47 text/x-vcard
jgras.vcf jan, 2017-10-17.16:24:01 text/x-vcard
Messages
New changeset 8312895b1377 by Cédric Krier in branch 'default':
Update purchase request view
http://hg.tryton.org/modules/sale_supply_drop_shipment/rev/8312895b1377
New changeset bcdf75191f88 by Cédric Krier in branch 'default':
Make description on sale line optional
http://hg.tryton.org/modules/sale/rev/bcdf75191f88
New changeset 00b026b1c8de by Cédric Krier in branch 'default':
Make description on purchase requisition line optional
http://hg.tryton.org/modules/purchase_requisition/rev/00b026b1c8de
New changeset 59d8692ccaa4 by Cédric Krier in branch 'default':
Make description on purchase request optional
http://hg.tryton.org/modules/purchase_request/rev/59d8692ccaa4
New changeset 861329995fbd by Cédric Krier in branch 'default':
Make description on purchase line optional
http://hg.tryton.org/modules/purchase/rev/861329995fbd
New changeset c1855683d0dc by Cédric Krier in branch 'default':
Make description on invoice line optional
http://hg.tryton.org/modules/account_invoice/rev/c1855683d0dc
review43781003 updated at https://codereview.tryton.org/43781003/#ps40001
review39911002 updated at https://codereview.tryton.org/39911002/#ps20001
review43781003 updated at https://codereview.tryton.org/43781003/#ps20001
New review44441002 at https://codereview.tryton.org/44441002/#ps1
New review40831002 at https://codereview.tryton.org/40831002/#ps1
New review38971002 at https://codereview.tryton.org/38971002/#ps1
New review39911002 at https://codereview.tryton.org/39911002/#ps1
New review43781003 at https://codereview.tryton.org/43781003/#ps1
New review43781002 at https://codereview.tryton.org/43781002/#ps1
msg36337 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-10-17.16:24:52
I agree that not filling the description will be a good improvement. 

Maybe we can use a functional field or property on reports in order to ease the customization by third party modules. By default the description or product name will be used.
msg36336 (view) Author: [hidden] (jan) Date: 2017-10-17.16:24:01
Am 17.10.2017 um 16:07 schrieb Cédric Krier:
> Cédric Krier <cedric.krier@b2ck.com> added the comment:
>
> For me, it has the same conceptual error as the current design, it replicate the data. If you want to have some specific data on the print report, just customize it.
That's true - so no description as default is fine. Other behavior
should be handled by custom modules.
msg36335 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-10-17.16:07:08
For me, it has the same conceptual error as the current design, it replicate the data. If you want to have some specific data on the print report, just customize it.
There is also a UX issue with the current design when the customer/supplier speak a different language as the user. The last one will see on the screen text in a foreign language that he may not understand.
msg36334 (view) Author: [hidden] (jan) Date: 2017-10-17.15:39:47
Am 17.10.2017 um 09:36 schrieb Cédric Krier:
> Instead of issue6824 and issue3797, I think we should not fill the description with the product record name. Indeed we should let the user fill with whatever he wants. The description should be required only if there is no product and reports must display both the product record name and the description (if not empty).
In all installations we have a custom module to let the user decide
which information should go to description:

None if product choosen  (like your proposition)
product.description - because a lot of users expect that the description
put on the product works like a template for description in the sale line

e.g.

Product Name:
Web Service Small

Product Description:
1 Database
10 E-mail-accounts
1GB Webspace

My preferred solution:

product.description goes to sale.line.description and for internal notes
you can use now the notes feature (or a field internal notes from custom
module)

Gruß, Jan
msg36323 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-10-17.09:36:11
Instead of issue6824 and issue3797, I think we should not fill the description with the product record name. Indeed we should let the user fill with whatever he wants. The description should be required only if there is no product and reports must display both the product record name and the description (if not empty).
History
Date User Action Args
2017-12-18 19:06:17roundup-botsetmessages: + msg37356
2017-12-18 19:05:47roundup-botsetmessages: + msg37355
2017-12-18 19:05:22roundup-botsetmessages: + msg37354
2017-12-18 19:04:31roundup-botsetmessages: + msg37353
2017-12-18 19:03:22roundup-botsetmessages: + msg37352
2017-12-18 19:02:52roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg37351
2017-12-18 18:39:10reviewbotsetmessages: + msg37350
2017-11-23 22:17:22reviewbotsetmessages: + msg37019
2017-11-21 21:19:22reviewbotsetmessages: + msg36996
2017-11-21 20:44:50reviewbotsetmessages: + msg36988

Showing 10 items. Show all history (warning: this could be VERY long)