Tryton - Issues



Title Icons in menu are not shown on gtk3
Priority feature Status chatting
Superseder Nosy List Timitos, ced
Type behavior Components tryton
Assigned To Keywords patch

Created on 2017-10-16.16:13:19 by Timitos, last changed by ced.

File name Uploaded Type Edit Remove
gtk3-menu-icons.patch Timitos, 2017-10-16.16:13:18 text/plain
msg37199 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-10.11:48:24
msg37185 (view) Author: [hidden] (Timitos) Date: 2017-12-09.18:21:04
After some research we found out that it seems to be a feature. The menuitems that have radio buttons or checkboxes have the same position for the checkbox/radiobutton than the images. In the newer versions of gtk+3 the proposal is not to use images on menu items any more. We think that this can be explained by the fact i explained above. It would mix images and checkboxes and radiobuttons on the same column.

With a css rule like the following the position of the images could be set back to the old behavior:

menuitem check, menuitem radio { min-width: 0px; }

But it will need to add some more complexity for something that may reintroduce a feature that has been removed by GTK+3 with purpose (as we think).

So i propose that we remove the icons from the menuitems of the top menubar completely.
msg36407 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-10-22.01:01:17
I have version 3.22.16 and I can see the images in the menu.
Are you sure you do not have gtk-menu-images set to False:
It may be deprecated but it is not removed. I think that as far as we support GTK+-2, we should not yet remove deprecated widgets (and when we will do it, we will have to replace everywhere).
msg36306 (view) Author: [hidden] (Timitos) Date: 2017-10-16.16:13:18
gtk.ImageMenuItem is deprecated[1] and does not work any more on current gtk version (tested with: 3.22.24).

Find attached a poc how get them work again.

Date User Action Args
2017-12-10 11:48:24cedsetstatus: need-eg -> chatting
priority: bug -> feature
type: behavior
messages: + msg37199
2017-12-09 18:21:04Timitossetmessages: + msg37185
2017-10-22 01:01:17cedsetstatus: unread -> need-eg
nosy: + ced
messages: + msg36407
2017-10-16 16:13:19Timitoscreate

Showing 10 items. Show all history (warning: this could be VERY long)