Tryton - Issues

 

Issue6719

Title Improve binary widget buttons
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components sao, tryton
Assigned To ced Keywords review
Reviews 37641002,35561002
View: 37641002, 35561002

Created on 2017-08-11.19:37:16 by ced, last changed by roundup-bot.

Messages
New changeset a23ab87f2e17 by Cédric Krier in branch 'default':
Improve binary/image buttons
http://hg.tryton.org/sao/rev/a23ab87f2e17
New changeset d5ca9502ec38 by Cédric Krier in branch 'default':
Improve binary/image buttons
http://hg.tryton.org/tryton/rev/d5ca9502ec38
review35561002 updated at https://codereview.tryton.org/35561002/#ps20001
msg35271 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-08-18.17:22:12
Fix open button on tryton and add a download on tree view of sao in last patchset.
For the edition on sao, this is how the client is designed. I do not think we should make an exception for binary.
review37641002 updated at https://codereview.tryton.org/37641002/#ps60001
msg35268 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-08-18.15:17:33
Another diferent I found. On sao, the binary buttons on the list are not available until the data is clicked. Can we make the buttons appear by default without requiring the user to click on the widget?
msg35267 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-08-18.15:13:44
On attachment list, i see the open icon on tryton but not on sao. Furthermore, if I click the open button on tryton it does nothing. So if there is nothing to do, I think we should not show it.
msg35144 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-08-12.01:03:23
I posted some screenshots: https://twitter.com/cedrickrier/status/896144903880691712
review35561002 updated at https://codereview.tryton.org/35561002/#ps1
review37641002 updated at https://codereview.tryton.org/37641002/#ps40001
review37641002 updated at https://codereview.tryton.org/37641002/#ps20001
review37641002 updated at https://codereview.tryton.org/37641002/#ps1
msg35135 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-08-11.19:37:15
Similar to issue4540, the set of buttons could be reworked to minimize errors.
So I propose to merge the clear/select button and move it at the end so it stays at the same place when clear is clicked so select can be clicked just after without moving.
I propose also to move the open button inside the filename entry as primary icon, like for the Many2One.
And I propose to hide the download button when there is no value.
History
Date User Action Args
2017-09-07 18:45:48roundup-botsetmessages: + msg35570
2017-09-07 18:44:59roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg35569
2017-08-18 17:41:23reviewbotsetmessages: + msg35273
2017-08-18 17:22:12cedsetmessages: + msg35271
2017-08-18 16:03:50reviewbotsetmessages: + msg35269
2017-08-18 15:17:33pokolisetmessages: + msg35268
2017-08-18 15:13:45pokolisetnosy: + pokoli
messages: + msg35267
2017-08-12 01:03:23cedsetmessages: + msg35144
2017-08-11 23:07:40reviewbotsetmessages: + msg35140
2017-08-11 23:07:23reviewbotsetmessages: + msg35139

Showing 10 items. Show all history (warning: this could be VERY long)