Tryton - Issues

 

Issue6714

Title Missing None check when searching for several values using ';'.
Priority bug Status resolved
Superseder Nosy List albertca, ced, reviewbot, roundup-bot
Type crash Components sao, tryton
Assigned To ced Keywords review
Reviews 41511002,35641002
View: 41511002, 35641002

Created on 2017-08-10.14:33:12 by albertca, last changed by roundup-bot.

Messages
New changeset dc8c3a088293 by Cédric Krier in branch '4.4':
Do not fail when completing selection with last value None
http://hg.tryton.org/sao/rev/dc8c3a088293

New changeset db91e630a35a by Cédric Krier in branch '4.2':
Do not fail when completing selection with last value None
http://hg.tryton.org/sao/rev/db91e630a35a

New changeset 3b9b149f1086 by Cédric Krier in branch '4.0':
Do not fail when completing selection with last value None
http://hg.tryton.org/sao/rev/3b9b149f1086

New changeset 93bcb821c8ff by Cédric Krier in branch '3.8':
Do not fail when completing selection with last value None
http://hg.tryton.org/sao/rev/93bcb821c8ff
New changeset 93ba0a520ceb by Albert Cervera i Areny in branch '4.4':
Do not fail when completing selection with last value None
http://hg.tryton.org/tryton/rev/93ba0a520ceb

New changeset eff0d86fcc7b by Albert Cervera i Areny in branch '4.2':
Do not fail when completing selection with last value None
http://hg.tryton.org/tryton/rev/eff0d86fcc7b

New changeset 272d8d027709 by Albert Cervera i Areny in branch '4.0':
Do not fail when completing selection with last value None
http://hg.tryton.org/tryton/rev/272d8d027709

New changeset 44d7346f04a3 by Albert Cervera i Areny in branch '3.8':
Do not fail when completing selection with last value None
http://hg.tryton.org/tryton/rev/44d7346f04a3

New changeset 78ae2f13fb60 by Albert Cervera i Areny in branch '3.6':
Do not fail when completing selection with last value None
http://hg.tryton.org/tryton/rev/78ae2f13fb60
New changeset ababf16e1d5f by Cédric Krier in branch 'default':
Do not fail when completing selection with last value None
http://hg.tryton.org/sao/rev/ababf16e1d5f
New changeset 64516e092b1d by Albert Cervera i Areny in branch 'default':
Do not fail when completing selection with last value None
http://hg.tryton.org/tryton/rev/64516e092b1d
review35641002 updated at https://codereview.tryton.org/35641002/#ps1
msg35964 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-09-30.15:05:31
Here is review35641002 for sao
msg35617 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-09-09.23:53:24
Missing sao patch
review41511002 updated at https://codereview.tryton.org/41511002/#ps20001
review41511002 updated at https://codereview.tryton.org/41511002/#ps1
msg35116 (view) Author: [hidden] (albertca) (Tryton committer) (Tryton translator) Date: 2017-08-10.14:33:11
Searching on a selection field where its possible values have spaces in between requires the user to use double quotes. In this scenario, in the Catalan language, searching on account.payment on the "Payment Kind" field, it crashes when the user introduces the last double quotes symbol:

"Classe de pagament": "A pagar";"

with the following traceback:

Traceback (most recent call last):
  File "/home/albert/d/hg/guillen/tryton/tryton/gui/window/view_form/view/screen_container.py", line 420, in keypress
    self.update()
  File "/home/albert/d/hg/guillen/tryton/tryton/gui/window/view_form/view/screen_container.py", line 320, in update
    res = self.screen.search_complete(self.get_text())
  File "/home/albert/d/hg/guillen/tryton/tryton/gui/window/view_form/screen/screen.py", line 242, in search_complete
    return list(self.domain_parser.completion(search_string))
  File "/home/albert/d/hg/guillen/tryton/tryton/common/domain_parser.py", line 993, in completion
    for complete in self.complete(ending):
  File "/home/albert/d/hg/guillen/tryton/tryton/common/domain_parser.py", line 1054, in complete
    for comp in complete_value(field, value):
  File "/home/albert/d/hg/guillen/tryton/tryton/common/domain_parser.py", line 690, in complete_selection
    test_value = test_value.strip('%')
AttributeError: 'NoneType' object has no attribute 'strip'
History
Date User Action Args
2017-10-17 20:49:52roundup-botsetmessages: + msg36343
2017-10-17 20:48:49roundup-botsetmessages: + msg36342
2017-10-05 22:34:15roundup-botsetmessages: + msg36093
2017-10-05 22:33:24roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg36092
2017-09-30 15:06:52reviewbotsetmessages: + msg35965
2017-09-30 15:05:32cedsetstatus: in-progress -> testing
reviews: 41511002 -> 41511002,35641002
messages: + msg35964
assignedto: albertca -> ced
2017-09-09 23:53:25cedsetstatus: testing -> in-progress
component: + sao
messages: + msg35617
nosy: + ced
2017-09-09 23:52:33cedsetstatus: in-progress -> testing
2017-08-18 00:42:30reviewbotsetmessages: + msg35244
2017-08-10 14:43:00reviewbotsetnosy: + reviewbot
messages: + msg35118

Showing 10 items. Show all history (warning: this could be VERY long)