Tryton - Issues

 

Issue6710

Title Error showing revisions with widget="selection"
Priority bug Status testing
Superseder Nosy List ced, perilla, reviewbot
Type crash Components sao
Assigned To ced Keywords patch, review
Reviews 43401002
View: 43401002

Created on 2017-08-08.23:36:23 by perilla, last changed by perilla.

Files
File name Uploaded Type Edit Remove
sao.diff perilla, 2017-08-09.05:03:13 text/plain
sao.png perilla, 2017-08-08.23:36:22 image/png
Messages
msg35103 (view) Author: [hidden] (perilla) Date: 2017-08-09.17:17:10
I tested your solution, and it works fine...
thanks.
review43401002 updated at https://codereview.tryton.org/43401002/#ps1
msg35097 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-08-09.09:17:29
I checked and the last_domain must stay null because it must be differentiated of empty domain.
Indeed it is the last_domain who has the wrong value stored, here is review43401002 that fix it.
msg35096 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-08-09.09:02:01
Please follow: http://www.tryton.org/how-to-contribute.html
msg35095 (view) Author: [hidden] (perilla) Date: 2017-08-09.05:03:13
This patch solves the problem, seem to be related
with last_domain, because get_domain function never
return null (instead return []).
msg35094 (view) Author: [hidden] (perilla) Date: 2017-08-09.04:58:29
traceback with development build

Uncaught TypeError: Cannot read property 'length' of undefined
    at Object.Sao.common.compare (tryton-sao.js:14160)
    at ClassConstructor._update_selection (tryton-sao.js:14781)
    at i (jquery.min.js:2)
    at Object.add [as done] (jquery.min.js:2)
    at ClassConstructor.Sao.common.selection_mixin.update_selection (tryton-sao.js:14818)
    at ClassConstructor.update_selection (tryton-sao.js:8743)
    at ClassConstructor.display_update_selection (tryton-sao.js:8762)
    at ClassConstructor.display (tryton-sao.js:8795)
    at tryton-sao.js:7576
    at i (jquery.min.js:2)
msg35093 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-08-09.00:05:16
Please, could you run a sao with a development build and post the traceback.
msg35092 (view) Author: [hidden] (perilla) Date: 2017-08-08.23:36:22
on sao, when I use "show revisions" option, and
my form have a Many2One field with widget="selection"
I have an error on browser console.
History
Date User Action Args
2017-08-09 17:17:10perillasetmessages: + msg35103
2017-08-09 09:32:07reviewbotsetnosy: + reviewbot
messages: + msg35098
2017-08-09 09:17:29cedsetstatus: need-eg -> testing
keyword: + review
messages: + msg35097
reviews: 43401002
assignedto: ced
type: crash
2017-08-09 09:02:02cedsetmessages: + msg35096
2017-08-09 05:03:14perillasetfiles: + sao.diff
messages: + msg35095
keyword: + patch
2017-08-09 04:58:30perillasetmessages: + msg35094
2017-08-09 00:05:16cedsetstatus: unread -> need-eg
nosy: + ced
messages: + msg35093
2017-08-08 23:36:23perillacreate

Showing 10 items. Show all history (warning: this could be VERY long)