Tryton - Issues

 

Issue6516

Title Not possibleto login with username string outside the 0x00 to 0xFF range
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type crash Components sao
Assigned To ced Keywords review
Reviews 34981002
View: 34981002

Created on 2017-05-19.12:44:36 by ced, last changed by roundup-bot.

Messages
New changeset 496949e3e272 by Cédric Krier in branch '4.4':
Use utoa instead of btoa to encode authorization session
http://hg.tryton.org/sao/rev/496949e3e272

New changeset 6b5b6cdded5b by Cédric Krier in branch '4.2':
Use utoa instead of btoa to encode authorization session
http://hg.tryton.org/sao/rev/6b5b6cdded5b

New changeset 48c80aa376f5 by Cédric Krier in branch '4.0':
Use utoa instead of btoa to encode authorization session
http://hg.tryton.org/sao/rev/48c80aa376f5
New changeset c4d3ac386d28 by Cédric Krier in branch 'default':
Use utoa instead of btoa to encode authorization session
http://hg.tryton.org/sao/rev/c4d3ac386d28
review34981002 updated at https://codereview.tryton.org/34981002/#ps1
msg33711 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-05-19.12:44:36
The method btoa does not work with unicode string outside the range: https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/btoa
This method is used to construct the Authorization session which contains the username.
We should use the solution to convert to ucs-2: https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/btoa#Unicode_strings
History
Date User Action Args
2017-06-13 10:00:21roundup-botsetmessages: + msg34033
2017-05-30 22:05:39roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg33812
2017-05-19 13:08:43reviewbotsetnosy: + reviewbot
messages: + msg33713
2017-05-19 12:46:21cedsetstatus: in-progress -> testing
reviews: 34981002
keyword: + review
2017-05-19 12:44:36cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)