Tryton - Issues

 

Issue6515

Title Move cost price to product level instead of template
Priority feature Status testing
Superseder Nosy List ced, oscar, perilla, reviewbot
Type feature request Components account_stock_continental, product, stock
Assigned To ced Keywords review
Reviews 41321002
View: 41321002

Created on 2017-05-18.16:44:11 by ced, last changed by oscar.

Messages
msg33722 (view) Author: [hidden] (oscar) (Tryton translator) Date: 2017-05-22.03:45:07
I think the current design template and product, it separated in two models just add unnecessary complexity to coding, and customers are confused with real difference between these, this complexity add bugs too.
msg33719 (view) Author: [hidden] (perilla) Date: 2017-05-19.17:44:34
Ok, indeed I think you're right.
msg33718 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-05-19.15:55:12
On 2017-05-19 15:41, Diego Abad wrote:
> IMHO I think list_price should be also moved from template to product.

I do not agree. Usually list price of the product will be a computation
of the list price on template with another parameter.
If you have hundred of variants and you have to record an increase of 1
to the price, you do not want to have to update all the variants but
just the template. This is exactly the goal of the template, share data
between variants.
msg33717 (view) Author: [hidden] (perilla) Date: 2017-05-19.15:41:31
Great work...
IMHO I think list_price should be also moved from template to product.
review41321002 updated at https://codereview.tryton.org/41321002/#ps1
msg33705 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-05-18.16:44:11
This is a topic that came back many times.
Indeed we should always store/compute such value at the lower level because it is always possible to aggregate later but the opposite is not possible.
This will also have the benefit to simplify the code as there will be no more need to test against Product and Template.
History
Date User Action Args
2017-05-22 03:45:07oscarsetnosy: + oscar
messages: + msg33722
2017-05-19 17:44:35perillasetmessages: + msg33719
2017-05-19 15:55:13cedsetmessages: + msg33718
2017-05-19 15:41:32perillasetnosy: + perilla
messages: + msg33717
2017-05-19 12:40:01reviewbotsetnosy: + reviewbot
messages: + msg33710
2017-05-19 12:37:36cedsetstatus: in-progress -> testing
reviews: 41321002
keyword: + review
2017-05-18 17:09:30cedlinkissue6108 superseder
2017-05-18 16:44:11cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)