Tryton - Issues

 

Issue6515

Title Move cost price to product level instead of template
Priority feature Status resolved
Superseder Nosy List ced, oscar, perilla, reviewbot, roundup-bot
Type feature request Components account_stock_continental, product, stock
Assigned To ced Keywords review
Reviews 41321002
View: 41321002

Created on 2017-05-18.16:44:11 by ced, last changed by roundup-bot.

Messages
New changeset 460b3c62a31c by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_supply_production/rev/460b3c62a31c
New changeset 65a447c019f0 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_supply_day/rev/65a447c019f0
New changeset afc07b55d336 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_supply/rev/afc07b55d336
New changeset 95d78362d42c by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_split/rev/95d78362d42c
New changeset 5136aaea0068 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_shipment_measurements/rev/5136aaea0068
New changeset 67855537ba80 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_product_location/rev/67855537ba80
New changeset 1afba32fbb8a by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_package_shipping_ups/rev/1afba32fbb8a
New changeset 569fc80aba81 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_package_shipping_dpd/rev/569fc80aba81
New changeset e7ba3d967eb1 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_package/rev/e7ba3d967eb1
New changeset 1c670c11d471 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_lot_sled/rev/1c670c11d471
New changeset 6da04fc855ae by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_lot/rev/6da04fc855ae
New changeset f45a3d0507ec by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock_forecast/rev/f45a3d0507ec
New changeset eb693c178dc7 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/stock/rev/eb693c178dc7
New changeset 53d217da54f1 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_supply_drop_shipment/rev/53d217da54f1
New changeset b6b706dfbb38 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_supply/rev/b6b706dfbb38
New changeset f7640f174f8b by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_subscription/rev/f7640f174f8b
New changeset 26d0e0730e59 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_stock_quantity/rev/26d0e0730e59
New changeset d7362a174c3c by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_shipment_grouping/rev/d7362a174c3c
New changeset 7b526e180353 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_shipment_cost/rev/7b526e180353
New changeset 9cfb658f90ac by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_promotion/rev/9cfb658f90ac
New changeset 39081eaffd70 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_price_list/rev/39081eaffd70
New changeset d32ad022fae3 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_opportunity/rev/d32ad022fae3
New changeset b995d86f4a7f by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_invoice_grouping/rev/b995d86f4a7f
New changeset af044022478e by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_extra/rev/af044022478e
New changeset f8cd524f4299 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_complaint/rev/f8cd524f4299
New changeset aab105041db8 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale_advance_payment/rev/aab105041db8
New changeset f0a538c3d7f7 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/sale/rev/f0a538c3d7f7
New changeset 7f2f21361817 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/purchase_shipment_cost/rev/7f2f21361817
New changeset ef344e838467 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/purchase_requisition/rev/ef344e838467
New changeset c34369c3bb36 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/purchase_request/rev/c34369c3bb36
New changeset 91ede4db9694 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/purchase_invoice_line_standalone/rev/91ede4db9694
New changeset e34ade9a3abd by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/purchase/rev/e34ade9a3abd
New changeset 57416f8b5d8a by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/project_invoice/rev/57416f8b5d8a
New changeset 339c811ef345 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/production_work/rev/339c811ef345
New changeset eba2e6fd469a by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/production/rev/eba2e6fd469a
New changeset d0418de6fb95 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/product_price_list/rev/d0418de6fb95
New changeset 467752c591f9 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/product_cost_history/rev/467752c591f9
New changeset 19ef73b7bcfc by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/product_cost_fifo/rev/19ef73b7bcfc
New changeset 190ed0daec25 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/product/rev/190ed0daec25
New changeset 7ce94619ad3b by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/customs/rev/7ce94619ad3b
New changeset 742f979e9c07 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/commission_waiting/rev/742f979e9c07
New changeset a6d1b471008c by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/commission/rev/a6d1b471008c
New changeset f63673ef9a59 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/carrier_weight/rev/f63673ef9a59
New changeset 1c73d90f6de6 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/carrier_percentage/rev/1c73d90f6de6
New changeset 5d8e04b6dc95 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/analytic_sale/rev/5d8e04b6dc95
New changeset 7e6deae6fe96 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/analytic_purchase/rev/7e6deae6fe96
New changeset 197677b41fc3 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/analytic_invoice/rev/197677b41fc3
New changeset cf0d822ca040 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/account_stock_landed_cost_weight/rev/cf0d822ca040
New changeset 113d7ae0b298 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/account_stock_landed_cost/rev/113d7ae0b298
New changeset 920105074a1a by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/account_stock_continental/rev/920105074a1a
New changeset 2735dcc91e24 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/account_stock_anglo_saxon/rev/2735dcc91e24
New changeset d5f023cbc7f2 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/account_product/rev/d5f023cbc7f2
New changeset 67e116210e53 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/account_invoice/rev/67e116210e53
New changeset a283fef24078 by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/account_dunning_fee/rev/a283fef24078
New changeset f97ac4491d0d by Cédric Krier in branch 'default':
Move cost price to product level instead of template
http://hg.tryton.org/modules/account_asset/rev/f97ac4491d0d
review41321002 updated at https://codereview.tryton.org/41321002/#ps40001
msg33889 (view) Author: [hidden] (oscar) (Tryton translator) Date: 2017-06-02.18:55:11
I dont sense have two models separated product and template, this issue is a good reason.
review41321002 updated at https://codereview.tryton.org/41321002/#ps20001
msg33722 (view) Author: [hidden] (oscar) (Tryton translator) Date: 2017-05-22.03:45:07
I think the current design template and product, it separated in two models just add unnecessary complexity to coding, and customers are confused with real difference between these, this complexity add bugs too.
msg33719 (view) Author: [hidden] (perilla) Date: 2017-05-19.17:44:34
Ok, indeed I think you're right.
msg33718 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-05-19.15:55:12
On 2017-05-19 15:41, Diego Abad wrote:
> IMHO I think list_price should be also moved from template to product.

I do not agree. Usually list price of the product will be a computation
of the list price on template with another parameter.
If you have hundred of variants and you have to record an increase of 1
to the price, you do not want to have to update all the variants but
just the template. This is exactly the goal of the template, share data
between variants.
msg33717 (view) Author: [hidden] (perilla) Date: 2017-05-19.15:41:31
Great work...
IMHO I think list_price should be also moved from template to product.
review41321002 updated at https://codereview.tryton.org/41321002/#ps1
msg33705 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-05-18.16:44:11
This is a topic that came back many times.
Indeed we should always store/compute such value at the lower level because it is always possible to aggregate later but the opposite is not possible.
This will also have the benefit to simplify the code as there will be no more need to test against Product and Template.
History
Date User Action Args
2017-07-05 14:53:47roundup-botsetmessages: + msg34481
2017-07-05 14:53:46roundup-botsetmessages: + msg34480
2017-07-05 14:53:45roundup-botsetmessages: + msg34479
2017-07-05 14:53:44roundup-botsetmessages: + msg34478
2017-07-05 14:53:43roundup-botsetmessages: + msg34477
2017-07-05 14:53:41roundup-botsetmessages: + msg34476
2017-07-05 14:53:40roundup-botsetmessages: + msg34475
2017-07-05 14:53:39roundup-botsetmessages: + msg34474
2017-07-05 14:53:38roundup-botsetmessages: + msg34473
2017-07-05 14:53:36roundup-botsetmessages: + msg34472

Showing 10 items. Show all history (warning: this could be VERY long)