Tryton - Issues

 

Issue6440

Title Wrong computation of move done
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type behavior Components purchase, sale
Assigned To ced Keywords review
Reviews 39311002,34911002
View: 39311002, 34911002

Created on 2017-04-13.13:26:18 by ced, last changed by roundup-bot.

Messages
New changeset d9604496c421 by C?dric Krier in branch 'default':
Fix get_move_done computation for returns
http://hg.tryton.org/modules/purchase/rev/d9604496c421
New changeset 6e707e5d268f by C?dric Krier in branch 'default':
Fix get_move_done computation for returns
http://hg.tryton.org/modules/sale/rev/6e707e5d268f
review34911002 updated at https://codereview.tryton.org/34911002/#ps1
review39311002 updated at https://codereview.tryton.org/39311002/#ps1
msg33222 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-04-13.13:26:17
The method does not take into account the sign of the quantity.
So in some case it could return wrongly True because it is a return (negative quantity) and all move are in the state done (but not all quantity has been created) so the the quantity computed will be negative.
History
Date User Action Args
2017-04-19 10:30:15roundup-botsetmessages: + msg33274
2017-04-19 10:29:36roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg33273
2017-04-13 13:38:07reviewbotsetmessages: + msg33224
2017-04-13 13:38:02reviewbotsetnosy: + reviewbot
messages: + msg33223
2017-04-13 13:30:28cedlinkissue6406 superseder
2017-04-13 13:30:01cedsetstatus: in-progress -> testing
reviews: 39311002,34911002
keyword: + review
2017-04-13 13:26:18cedcreate