Tryton - Issues

 

Issue6378

Title SQLite uses a custom sintax for Trim Operator
Priority feature Status resolved
Superseder Nosy List pokoli, reviewbot, roundup-bot
Type feature request Components trytond
Assigned To pokoli Keywords review
Reviews 31221002
View: 31221002

Created on 2017-03-20.12:47:15 by pokoli, last changed by roundup-bot.

Messages
New changeset 14f77d03e957 by Sergi Almacellas Abellana in branch '4.2':
Support position argument of Trim function in sqlite
http://hg.tryton.org/trytond/rev/14f77d03e957

New changeset b048a2b689b6 by Sergi Almacellas Abellana in branch '4.0':
Support position argument of Trim function in sqlite
http://hg.tryton.org/trytond/rev/b048a2b689b6

New changeset 22ce9b835beb by Sergi Almacellas Abellana in branch '3.8':
Support position argument of Trim function in sqlite
http://hg.tryton.org/trytond/rev/22ce9b835beb

New changeset 22e37acad917 by Sergi Almacellas Abellana in branch '3.6':
Support position argument of Trim function in sqlite
http://hg.tryton.org/trytond/rev/22e37acad917

New changeset d8cb5292a23b by Sergi Almacellas Abellana in branch '3.4':
Support position argument of Trim function in sqlite
http://hg.tryton.org/trytond/rev/d8cb5292a23b
New changeset 88517bd7b55b by Sergi Almacellas Abellana in branch 'default':
Support position argument of Trim function in sqlite
http://hg.tryton.org/trytond/rev/88517bd7b55b
review31221002 updated at https://codereview.tryton.org/31221002/#ps1
msg32608 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-03-20.12:47:15
Sqlite trim function [1] does not support the position argument but instead it uses the LTRIM and RTRIM functions for it. 

This function is used for the product_cost_history module in order to compute the history data [2]

So in order to support this module on sqlite we must provide a mapping function for Trim on SQLITe which return the valid function depending on the position argument. 

[1] https://www.sqlite.org/lang_corefunc.html#trim
[2] http://hg.tryton.org/modules/product_cost_history/file/6a2e94ade5b9/product.py#l46
History
Date User Action Args
2017-04-06 12:35:23roundup-botsetmessages: + msg33135
2017-03-22 11:59:48roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg32667
2017-03-20 13:08:03reviewbotsetnosy: + reviewbot
messages: + msg32610
2017-03-20 12:50:57pokolisetstatus: in-progress -> testing
reviews: 31221002
component: + trytond
keyword: + review
2017-03-20 12:47:15pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)