Tryton - Issues

 

Issue6370

Title Use reference as origin name
Priority feature Status resolved
Superseder Nosy List Timitos, ced, reviewbot, roundup-bot
Type feature request Components purchase, sale
Assigned To ced Keywords review
Reviews 33241002,30161003
View: 33241002, 30161003

Created on 2017-03-16.17:45:45 by ced, last changed by roundup-bot.

Messages
New changeset 22cd08efbc3c by C?dric Krier in branch 'default':
Use reference as origin name if filled
http://hg.tryton.org/modules/purchase/rev/22cd08efbc3c
New changeset 444a4bb3eb08 by C?dric Krier in branch 'default':
Use reference as origin name if filled
http://hg.tryton.org/modules/sale/rev/444a4bb3eb08
msg32561 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-03-16.23:59:06
Please point me where it is used outside the report?
msg32560 (view) Author: [hidden] (Timitos) Date: 2017-03-16.20:29:38
On 16.03.2017 17:45, Cédric Krier wrote:
> New submission from Cédric Krier <cedric.krier@b2ck.com>:
>
> The origin name is used on invoices and shipments in the report as reference.
> Indeed if there is a reference on the sale, it is often because the customer requested to have it on all documents (ex: invoice and delivery note). So I think in such case the origin name should be the reference if filled.
> The same apply on the purchase if the user entered a supplier reference, this reference will probably be also on the invoice.
I am not sure if this is a good idea. The origin value is not only used
on the report but also all over the application. With this change you
force the user to work with third party references in his application
instead of the internal ones he is used to. I think the origin should be
kept as it is now. The reference value should be added to the reports
additionally.
review30161003 updated at https://codereview.tryton.org/30161003/#ps1
review33241002 updated at https://codereview.tryton.org/33241002/#ps1
msg32549 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-03-16.17:45:44
The origin name is used on invoices and shipments in the report as reference.
Indeed if there is a reference on the sale, it is often because the customer requested to have it on all documents (ex: invoice and delivery note). So I think in such case the origin name should be the reference if filled.
The same apply on the purchase if the user entered a supplier reference, this reference will probably be also on the invoice.
History
Date User Action Args
2017-03-29 22:41:08roundup-botsetmessages: + msg32904
2017-03-29 22:40:20roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg32903
2017-03-16 23:59:07cedsetmessages: + msg32561
2017-03-16 20:29:38Timitossetnosy: + Timitos
messages: + msg32560
2017-03-16 18:05:36reviewbotsetmessages: + msg32552
2017-03-16 18:05:31reviewbotsetnosy: + reviewbot
messages: + msg32551
2017-03-16 17:48:41cedsetstatus: in-progress -> testing
reviews: 33241002,30161003
keyword: + review
2017-03-16 17:45:45cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)