Tryton - Issues

 

Issue6363

Title Sort xxx2Many with more records than client limit
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type behavior Components sao, tryton, trytond
Assigned To ced Keywords review
Reviews 33201002,33211002,32161002
View: 33201002, 33211002, 32161002

Created on 2017-03-14.15:51:07 by ced, last changed by roundup-bot.

Messages
New changeset eaf3aa51f97c by C?dric Krier in branch 'default':
Use None as limit for xxx2Many and menu
http://hg.tryton.org/sao/rev/eaf3aa51f97c
New changeset 5f4d068b8dd0 by C?dric Krier in branch 'default':
Use None as limit for xxx2Many and menu
http://hg.tryton.org/tryton/rev/5f4d068b8dd0
New changeset c1afac23188f by C?dric Krier in branch 'default':
Allow None limit in action window
http://hg.tryton.org/trytond/rev/c1afac23188f
review32161002 updated at https://codereview.tryton.org/32161002/#ps1
review33211002 updated at https://codereview.tryton.org/33211002/#ps1
review33201002 updated at https://codereview.tryton.org/33201002/#ps1
msg32502 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-03-14.15:51:06
The sort on a list view uses the search_filter to retrieve the list of ids but this method uses the default client limit to perform the query. If the xxx2many (which is not restricted by the client limit) has more records then this limit, the sorting can not be done properly because we will not receive all the ids sorted.
Indeed the screen should manage None as limit and we should set it for all xxx2Many screen.
History
Date User Action Args
2017-03-23 23:05:06roundup-botsetmessages: + msg32737
2017-03-23 23:04:02roundup-botsetmessages: + msg32736
2017-03-23 23:01:36roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg32735
2017-03-14 15:58:32reviewbotsetmessages: + msg32506
2017-03-14 15:58:16reviewbotsetmessages: + msg32505
2017-03-14 15:57:59reviewbotsetnosy: + reviewbot
messages: + msg32504
2017-03-14 15:56:20cedsetstatus: in-progress -> testing
reviews: 33201002,33211002,32161002
keyword: + review
2017-03-14 15:51:07cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)