Tryton - Issues

 

Issue6348

Title Column creation should be more abstract in order to allow backends to define themselves how to create special columns
Priority feature Status testing
Superseder Nosy List ced, nicoe, reviewbot
Type feature request Components trytond
Assigned To nicoe Keywords review
Reviews 26231002, 31181002
View: 26231002, 31181002

Created on 2017-03-10.15:44:22 by nicoe, last changed by reviewbot.

Messages
review26231002 updated at https://codereview.tryton.org/26231002/#ps130002
review26231002 updated at https://codereview.tryton.org/26231002/#ps110001
review26231002 updated at https://codereview.tryton.org/26231002/#ps90001
review26231002 updated at https://codereview.tryton.org/26231002/#ps70001
msg32535 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-03-16.12:11:44
For me, they are different but should share the same concept.
msg32533 (view) Author: [hidden] (nicoe) (Tryton committer) (Tryton translator) Date: 2017-03-16.12:04:13
* Cédric Krier  [2017-03-15 15:43 +0100]: 
>
>Cédric Krier <cedric.krier@b2ck.com> added the comment:
>
>Indeed I think this change should reuse the same "SQL type" as in issue6351.
>This will allow to drop extra parameter like the size and other like
>column_format which should be computed any way by the backend.

Shouldn't we close this issue then and supersed it with issue6351 ?
msg32521 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-03-15.15:43:44
Indeed I think this change should reuse the same "SQL type" as in issue6351.
This will allow to drop extra parameter like the size and other like column_format which should be computed any way by the backend.
review26231002 updated at https://codereview.tryton.org/26231002/#ps50001
review26231002 updated at https://codereview.tryton.org/26231002/#ps30008
review26231002 updated at https://codereview.tryton.org/26231002/#ps20001
New review31181002 at https://codereview.tryton.org/31181002/#ps1
New review26231002 at https://codereview.tryton.org/26231002/#ps1
msg32404 (view) Author: [hidden] (nicoe) (Tryton committer) (Tryton translator) Date: 2017-03-10.15:44:21
The column creation process use the add_raw_column methods from the backend which works great for default SQL types but fails for example in the case of geographic types because the latter needs to call the 'AddGeometryColumn' function.

I think that we could gain some flexibility in the column creation process if instead of passing to add_raw_column all the types, string, etc we were using only the field.
History
Date User Action Args
2017-03-23 17:34:19reviewbotsetmessages: + msg32722
2017-03-23 13:06:35reviewbotsetmessages: + msg32704
2017-03-21 19:10:16reviewbotsetmessages: + msg32634
2017-03-16 18:39:38reviewbotsetmessages: + msg32558
2017-03-16 12:11:44cedsetmessages: + msg32535
2017-03-16 12:04:13nicoesetmessages: + msg32533
2017-03-15 15:43:44cedsetnosy: + ced
messages: + msg32521
2017-03-15 10:28:25reviewbotsetmessages: + msg32514
2017-03-14 14:32:56reviewbotsetmessages: + msg32499
2017-03-14 12:37:51reviewbotsetmessages: + msg32492

Showing 10 items. Show all history (warning: this could be VERY long)