Tryton - Issues

 

Issue6248

Title Tax of loop not used in determination of taxes
Priority bug Status resolved
Superseder Nosy List ced, pokoli, ralf, reviewbot, roundup-bot
Type behavior Components sale_shipment_cost
Assigned To ralf Keywords review
Reviews 33861002
View: 33861002

Created on 2017-02-07.11:47:27 by ralf, last changed by roundup-bot.

Messages
New changeset c5b9703ad447 by Ralf Peschke in branch '4.2':
Use tax for checking the rule
http://hg.tryton.org/modules/sale_shipment_cost/rev/c5b9703ad447

New changeset 93cbf5135b0d by Ralf Peschke in branch '4.0':
Use tax for checking the rule
http://hg.tryton.org/modules/sale_shipment_cost/rev/93cbf5135b0d

New changeset c117b3f782f4 by Ralf Peschke in branch '3.8':
Use tax for checking the rule
http://hg.tryton.org/modules/sale_shipment_cost/rev/c117b3f782f4

New changeset 489aef646d9b by Ralf Peschke in branch '3.6':
Use tax for checking the rule
http://hg.tryton.org/modules/sale_shipment_cost/rev/489aef646d9b

New changeset 2acabb0b9375 by Ralf Peschke in branch '3.4':
Use tax for checking the rule
http://hg.tryton.org/modules/sale_shipment_cost/rev/2acabb0b9375
New changeset 3afa3700148f by Ralf Peschke in branch 'default':
Use tax for checking the rule
http://hg.tryton.org/modules/sale_shipment_cost/rev/3afa3700148f
review33861002 updated at https://codereview.tryton.org/33861002/#ps20001
msg32073 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-02-20.17:41:28
Indeed there should be two calls to apply one for each tax and one with None like it is done in other modules.
review33861002 updated at https://codereview.tryton.org/33861002/#ps1
msg31753 (view) Author: [hidden] (ralf) Date: 2017-02-07.11:47:26
In http://hg.tryton.org/modules/sale_shipment_cost/file/tip/stock.py#l114 there is a loop about the product.customer_taxes_used. But instead of using this tax in calling the apply-method there is a 'None' used.
I think this should be the tax, otherwise there is no correct match depending on tax possible.
History
Date User Action Args
2017-02-25 19:17:36roundup-botsetmessages: + msg32207
2017-02-23 00:32:24roundup-botsetstatus: chatting -> resolved
nosy: + roundup-bot
messages: + msg32136
2017-02-20 18:10:17reviewbotsetmessages: + msg32074
2017-02-20 17:41:28cedsetnosy: + ced
messages: + msg32073
2017-02-20 17:35:45reviewbotsetstatus: unread -> chatting
nosy: + reviewbot
messages: + msg32071
2017-02-20 17:21:27ralfsetreviews: 33861002
keyword: + review
2017-02-08 11:06:48ralfsetassignedto: ralf
2017-02-07 14:56:15pokolisetnosy: + pokoli
2017-02-07 11:47:27ralfcreate

Showing 10 items. Show all history (warning: this could be VERY long)