Tryton - Issues

 

Issue6104

Title keyboard shortcuts for sao
Priority feature Status chatting
Superseder Nosy List ced, perilla, pokoli, reviewbot
Type feature request Components sao
Assigned To perilla Keywords review
Reviews 32881002
View: 32881002

Created on 2016-12-10.05:44:28 by perilla, last changed by reviewbot.

Messages
review32881002 updated at https://codereview.tryton.org/32881002/#ps510001
review32881002 updated at https://codereview.tryton.org/32881002/#ps490001
review32881002 updated at https://codereview.tryton.org/32881002/#ps470001
review32881002 updated at https://codereview.tryton.org/32881002/#ps450001
review32881002 updated at https://codereview.tryton.org/32881002/#ps430001
review32881002 updated at https://codereview.tryton.org/32881002/#ps410001
review32881002 updated at https://codereview.tryton.org/32881002/#ps390001
review32881002 updated at https://codereview.tryton.org/32881002/#ps370001
review32881002 updated at https://codereview.tryton.org/32881002/#ps350001
review32881002 updated at https://codereview.tryton.org/32881002/#ps330001
review32881002 updated at https://codereview.tryton.org/32881002/#ps310001
review32881002 updated at https://codereview.tryton.org/32881002/#ps290001
review32881002 updated at https://codereview.tryton.org/32881002/#ps270001
review32881002 updated at https://codereview.tryton.org/32881002/#ps250001
review32881002 updated at https://codereview.tryton.org/32881002/#ps230001
review32881002 updated at https://codereview.tryton.org/32881002/#ps210001
review32881002 updated at https://codereview.tryton.org/32881002/#ps190001
review32881002 updated at https://codereview.tryton.org/32881002/#ps170001
review32881002 updated at https://codereview.tryton.org/32881002/#ps150001
review32881002 updated at https://codereview.tryton.org/32881002/#ps130001
msg30679 (view) Author: [hidden] (perilla) Date: 2016-12-12.15:31:24
Seems that chrome prevent redefine certain ctrl shortcuts

https://github.com/ccampbell/mousetrap/issues/159
https://github.com/ccampbell/mousetrap/issues/172
https://github.com/chieffancypants/angular-hotkeys/issues/157
msg30678 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-12-12.14:56:03
I think we should look at our shortcuts and compare with the shortcuts of popular browsers (chrome, firefox, IE and Safari). We should take the decision according to how much conflict there are and how bad they are.
msg30677 (view) Author: [hidden] (perilla) Date: 2016-12-12.14:50:47
Because ctrl keys are used by browser, but I think
that we can decide between (ctrl or alt).
msg30663 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2016-12-12.09:10:49
Why are you sugesting the alt keywork instead of ctrl key? 

I prefer the same behaviour as gtk client. 

P.S: If you plan to work on the issue please assign it to yourself.
review32881002 updated at https://codereview.tryton.org/32881002/#ps100001
review32881002 updated at https://codereview.tryton.org/32881002/#ps80001
review32881002 updated at https://codereview.tryton.org/32881002/#ps60001
review32881002 updated at https://codereview.tryton.org/32881002/#ps40001
review32881002 updated at https://codereview.tryton.org/32881002/#ps20001
New review32881002 at https://codereview.tryton.org/32881002/#ps1
msg30645 (view) Author: [hidden] (perilla) Date: 2016-12-10.05:50:03
However I think that we should use alt key instead of ctrl key
I add a initial review32881002
msg30644 (view) Author: [hidden] (perilla) Date: 2016-12-10.05:44:27
I am wondering if we add  key shortcuts on sao...
History
Date User Action Args
2017-03-07 21:35:51reviewbotsetmessages: + msg32333
2017-02-20 14:37:30reviewbotsetmessages: + msg32064
2017-02-14 14:39:32reviewbotsetmessages: + msg31918
2017-02-13 17:39:27perillasettitle: key shortcuts for sao -> keyboard shortcuts for sao
2017-02-12 05:14:49reviewbotsetmessages: + msg31878
2017-02-01 18:17:32reviewbotsetmessages: + msg31648
2017-01-27 17:17:13reviewbotsetmessages: + msg31527
2017-01-27 16:48:57reviewbotsetmessages: + msg31522
2017-01-23 23:40:23reviewbotsetmessages: + msg31460
2017-01-23 22:38:59reviewbotsetmessages: + msg31458
2017-01-20 15:38:29reviewbotsetmessages: + msg31394
2017-01-20 14:13:47reviewbotsetmessages: + msg31389
2017-01-20 06:11:55reviewbotsetmessages: + msg31378
2017-01-08 18:48:25reviewbotsetmessages: + msg31145
2017-01-08 05:44:58reviewbotsetmessages: + msg31141
2016-12-15 14:01:52reviewbotsetmessages: + msg30769
2016-12-14 21:02:59reviewbotsetmessages: + msg30750
2016-12-14 19:29:03reviewbotsetmessages: + msg30749
2016-12-14 13:55:31reviewbotsetmessages: + msg30738
2016-12-14 12:02:43reviewbotsetmessages: + msg30734
2016-12-13 14:33:28reviewbotsetmessages: + msg30698
2016-12-12 15:31:24perillasetmessages: + msg30679
2016-12-12 14:56:03cedsetnosy: + ced
messages: + msg30678
2016-12-12 14:50:48perillasetmessages: + msg30677
2016-12-12 14:47:19perillasetassignedto: perilla
2016-12-12 09:10:50pokolisettype: feature request
messages: + msg30663
nosy: + pokoli
2016-12-12 04:53:03reviewbotsetmessages: + msg30661
2016-12-12 04:34:41reviewbotsetmessages: + msg30660
2016-12-11 06:24:27reviewbotsetmessages: + msg30652
2016-12-11 04:25:32reviewbotsetmessages: + msg30651
2016-12-10 14:01:53reviewbotsetmessages: + msg30647
2016-12-10 06:02:12reviewbotsetnosy: + reviewbot
messages: + msg30646
2016-12-10 06:02:12reviewbotsetreviews: 32881002
keyword: + review
2016-12-10 05:50:03perillasetstatus: unread -> chatting
messages: + msg30645
2016-12-10 05:44:28perillacreate