Created on 2016-11-04.02:05:46 by ced, last changed 40 months ago by roundup-bot.
New changeset 08ea1ea4a567 by Cédric Krier in branch 'default': Use tax code line for tax reporting http://hg.tryton.org/modules/account_tax_cash/rev/08ea1ea4a567
New changeset 95d8e64d85f9 by Cédric Krier in branch 'default': Update chart to new tax code definition http://hg.tryton.org/modules/account_de_skr03/rev/95d8e64d85f9
New changeset 84c123a1318f by Cédric Krier in branch 'default': Update chart to new tax code definition http://hg.tryton.org/modules/account_fr/rev/84c123a1318f
New changeset fc45ef5806a1 by Cédric Krier in branch 'default': Update chart to new tax code definition http://hg.tryton.org/modules/account_be/rev/fc45ef5806a1
New changeset 995f1f901ceb by Cédric Krier in branch 'default': Remove tax code http://hg.tryton.org/modules/account_eu/rev/995f1f901ceb
New changeset f45f42b6b358 by Cédric Krier in branch 'default': Remove tax code from invoice tax http://hg.tryton.org/modules/account_invoice/rev/f45f42b6b358
New changeset 9135d0ac6abd by Cédric Krier in branch 'default': Use tax code line for tax reporting http://hg.tryton.org/modules/account/rev/9135d0ac6abd
Ready for testing as we have decided to not wait for account_es  (for which this feature will help the rewrite)  https://groups.google.com/d/msg/tryton/qZIRTarG14w/pvNhW5Z1BAAJ
Those reviews contain some modification from issue7139. Indeed in order to be able to clean the previous duplicate tax lines with a SQL query, we can not have account_tax_cash module installed before. So the two issues will need to be pushed together to be in the same release.
Indeed I think we should go with a more radical design. There is no need to have a single tax code per tax as we already have the tax. So I think we could have: - remove tax code from the tax definition and tax line - add on tax line selection: tax/base - compute sum's per tax instead of tax code - define an amount on tax code by summing a set of tax sum's The sum's on taxes are all the combination of tax/base and credit. The definition of the amount on tax code is a One2Many with: - operation: +/- - tax: many2one - amount: tax/base - type: any/debit/credit The migration of existing will just need to look at the combination: tax/code in the account_tax to define if it is a tax or a base.
Indeed I think the tax code should be completely redesigned. For me, the tax report of some countries are too complex to be just computed with sum (see issue6404). So I propose to create a new flat model which will contains a formula using the tax code values (using simpleeval). This way we could use a single tax code per taxes and reuse it in many formula without being tight by a tree structure. For backward compatibility we could keep the tree structure of the tax code even if it is no more useful.
|2018-09-23 13:08:15||ced||link||issue4613 superseder|
|2018-03-25 23:39:45||roundup-bot||set||messages: + msg39366|
|2018-03-25 23:38:47||roundup-bot||set||messages: + msg39365|
|2018-03-25 23:37:15||roundup-bot||set||messages: + msg39364|
|2018-03-25 23:36:07||roundup-bot||set||messages: + msg39363|
|2018-03-25 23:35:24||roundup-bot||set||messages: + msg39362|
|2018-03-25 23:34:48||roundup-bot||set||messages: + msg39361|
|2018-03-25 23:33:51||roundup-bot||set||status: testing -> resolved|
nosy: + roundup-bot
messages: + msg39360
|2018-03-24 17:50:07||reviewbot||set||messages: + msg39334|
|2018-03-24 17:50:06||reviewbot||set||reviews: 40171002, 41941002, 44181002, 44751002, 45281002, 44761002 -> 40171002, 41941002, 44181002, 44751002, 45281002, 44761002, 40221002|
Showing 10 items. Show all history (warning: this could be VERY long)