Tryton - Issues

 

Issue5834

Title The party_siret module should use party.identifier
Priority feature Status testing
Superseder Nosy List nicoe, reviewbot, risto3
Type behavior Components party_siret
Assigned To nicoe Keywords easy, review
Reviews 21241002
View: 21241002

Created on 2016-08-26.10:39:34 by nicoe, last changed by risto3.

Messages
msg47371 (view) Author: [hidden] (risto3) Date: 2019-03-03.23:31:14
I guess as mentioned in https://discuss.tryton.org/t/party-identifiers-as-references/1210 that I believe it worthwhile to add a optional Many2One address field to PartyIdentifier allowing the identifier to be on the tuple party/address and not only on party.

This would allow, for one thing, stdnum's fr.siret to be used, not to mention any other physical address based party identifier (such as the French public school identifier).

The UI wouldn't be overly complex, on the contrary turns this into a powerful, extendable utility.
New review21241002 at https://codereview.tryton.org/21241002/#ps20001
msg28159 (view) Author: [hidden] (nicoe) (Tryton committer) Date: 2016-08-28.19:27:50
Here is the review: https://codereview.tryton.org/21241002/
msg28119 (view) Author: [hidden] (nicoe) (Tryton committer) Date: 2016-08-26.10:39:33
The party_siren module adds a siren field on the party. It should use the standard party.identifier way of doing thing.
History
Date User Action Args
2019-03-03 23:31:14risto3setnosy: + risto3
messages: + msg47371
2016-09-16 23:27:30reviewbotsetnosy: + reviewbot
messages: + msg28823
2016-09-16 23:27:29reviewbotsetreviews: 21241002
keyword: + review
2016-08-28 19:27:51nicoesetstatus: unread -> testing
assignedto: nicoe
messages: + msg28159
2016-08-26 10:54:58pokolisetkeyword: + easy
2016-08-26 10:39:34nicoecreate

Showing 10 items. Show all history (warning: this could be VERY long)