Issue 5834
- Title
- The party_siret module should use party.identifier
- Priority
- feature
- Status
- resolved
- Nosy list
- ced, nicoe, reviewbot, risto3, roundup-bot
- Assigned to
- ced
- Keywords
- easy, review
Created on 2016-08-26.10:39:34 by nicoe, last changed 4 months ago by roundup-bot.
Messages
New changeset 26c5c996fa56 by Cédric Krier in branch 'default': Update scenario to use identifier for siren https://hg.tryton.org/tryton-env/rev/26c5c996fa56
New changeset 75fa4537b708 by Cédric Krier in branch 'default': Update scenario to use identifier for siren https://hg.tryton.org/modules/account_fr/rev/75fa4537b708
New changeset 29f2fb9a5f59 by Cédric Krier in branch 'default': Use party identifier to store SIREN and SIRET https://hg.tryton.org/tryton-env/rev/29f2fb9a5f59
New changeset f5c2c4885143 by Cédric Krier in branch 'default': Use party identifier to store SIREN and SIRET https://hg.tryton.org/modules/party_siret/rev/f5c2c4885143
New changeset 11eaa6492bfc by Cédric Krier in branch 'default': Use party identifier to store SIREN and SIRET https://hg.tryton.org/modules/party/rev/11eaa6492bfc
I revived this change by implementing the same design as the product supplier on party identifier with the address. This way review397071002 can store in the identifier the SIREN and SIRET.
I guess as mentioned in https://discuss.tryton.org/t/party-identifiers-as-references/1210 that I believe it worthwhile to add a optional Many2One address field to PartyIdentifier allowing the identifier to be on the tuple party/address and not only on party. This would allow, for one thing, stdnum's fr.siret to be used, not to mention any other physical address based party identifier (such as the French public school identifier). The UI wouldn't be overly complex, on the contrary turns this into a powerful, extendable utility.
Here is the review: https://codereview.tryton.org/21241002/
The party_siren module adds a siren field on the party. It should use the standard party.identifier way of doing thing.
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-02-13 01:23:47 | roundup-bot | set | messages: + msg74081 |
| 2022-02-13 01:23:33 | roundup-bot | set | messages: + msg74080 |
| 2022-02-13 00:44:26 | roundup-bot | set | messages: + msg74076 |
| 2022-02-13 00:44:19 | roundup-bot | set | messages: + msg74075 |
| 2022-02-13 00:44:15 | roundup-bot | set | messages:
+ msg74074 nosy: + roundup-bot status: testing -> resolved |
| 2022-01-13 18:14:17 | reviewbot | set | messages: + msg73237 |
| 2022-01-13 18:07:39 | ced | set | assignedto: nicoe -> ced messages: + msg73236 nosy: + ced reviews: 21241002 -> 397071002 |
| 2020-01-31 19:27:21 | reviewbot | set | messages: + msg55166 |
| 2019-03-03 23:31:14 | risto3 | set | nosy:
+ risto3 messages: + msg47371 |
| 2016-09-16 23:27:30 | reviewbot | set | nosy:
+ reviewbot messages: + msg28823 |
Showing 10 items. Show all history (warning: this could be VERY long)