Tryton - Issues

 

Issue5769

Title Use like instead of ilike for Reference fields
Priority feature Status chatting
Superseder Nosy List albertca, ced, reviewbot
Type performance Components
Assigned To Keywords review
Reviews 42071002
View: 42071002

Created on 2016-08-06.16:57:39 by ced, last changed by albertca.

Files
File name Uploaded Type Edit Remove
unnamed albertca, 2016-08-09.01:26:25 text/plain
Messages
msg42925 (view) Author: [hidden] (albertca) (Tryton committer) (Tryton translator) Date: 2018-08-16.14:35:01
Updated review https://codereview.tryton.org/42071002/#ps40001 changes the only module found that also used ilike instead of like.
review42071002 updated at https://codereview.tryton.org/42071002/#ps40001
msg40587 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-05-09.09:43:55
review42071002 is not complete, all modules should be reviewed.
msg27755 (view) Author: [hidden] (albertca) (Tryton committer) (Tryton translator) Date: 2016-08-17.12:57:37
2016-08-09 12:25 GMT+02:00 Cédric Krier <issue_tracker@tryton.org>:
>
> Cédric Krier <cedric.krier@b2ck.com> added the comment:
>
> On 2016-08-09 01:26, Albert Cervera i Areny wrote:
>> 2016-08-06 16:57 GMT+02:00 Cédric Krier <issue_tracker@tryton.org>:
>> > New submission from Cédric Krier <cedric.krier@b2ck.com>:
>> >
>> > In many places, we use ilike operator to select the model part of the
>> > reference field. But a like operator will be enough and so a simple index
>> > on the column could be used.
>> >
>>
>> I disagree. Reference field can contain alfanumeric characters and it would
>> be surprising for the user that we're case insensitive in all searches
>> except for reference. Also I don't see a reason for that.
>
> Could you point to a use case where user enter the model name?
> For me, it never happens and if there are cases, they must be removed.

Sorry, re-reading I realize I misunderstood the proposal.

Sorry for the noise.

> _______________________________________________
> Tryton issue tracker <issue_tracker@tryton.org>
> <https://bugs.tryton.org/issue5769>
> _______________________________________________
msg27593 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-08-09.12:25:10
On 2016-08-09 01:26, Albert Cervera i Areny wrote:
> 2016-08-06 16:57 GMT+02:00 Cédric Krier <issue_tracker@tryton.org>:
> > New submission from Cédric Krier <cedric.krier@b2ck.com>:
> >
> > In many places, we use ilike operator to select the model part of the
> > reference field. But a like operator will be enough and so a simple index
> > on the column could be used.
> >
> 
> I disagree. Reference field can contain alfanumeric characters and it would
> be surprising for the user that we're case insensitive in all searches
> except for reference. Also I don't see a reason for that.

Could you point to a use case where user enter the model name?
For me, it never happens and if there are cases, they must be removed.
msg27585 (view) Author: [hidden] (albertca) (Tryton committer) (Tryton translator) Date: 2016-08-09.01:26:25
2016-08-06 16:57 GMT+02:00 Cédric Krier <issue_tracker@tryton.org>:

>
> New submission from Cédric Krier <cedric.krier@b2ck.com>:
>
> In many places, we use ilike operator to select the model part of the
> reference field. But a like operator will be enough and so a simple index
> on the column could be used.
>

I disagree. Reference field can contain alfanumeric characters and it would
be surprising for the user that we're case insensitive in all searches
except for reference. Also I don't see a reason for that.

> ----------
> messages: 27567
> nosy: ced
> priority: feature
> status: unread
> title: Use like instead of ilike for Reference fields
> type: performance
>
> _______________________________________________
> Tryton issue tracker <issue_tracker@tryton.org>
> <https://bugs.tryton.org/issue5769>
> _______________________________________________
>
msg27567 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-08-06.16:57:38
In many places, we use ilike operator to select the model part of the reference field. But a like operator will be enough and so a simple index on the column could be used.
History
Date User Action Args
2018-08-16 14:35:01albertcasetmessages: + msg42925
2018-08-16 14:14:02reviewbotsetnosy: + reviewbot
messages: + msg42923
2018-05-09 09:43:55cedsetreviews: 42071002
messages: + msg40587
keyword: + review
2018-04-10 10:44:29cedlinkissue7339 superseder
2016-08-17 12:57:37albertcasetmessages: + msg27755
2016-08-09 12:25:10cedsetmessages: + msg27593
2016-08-09 01:26:26albertcasetfiles: + unnamed
status: unread -> chatting
messages: + msg27585
nosy: + albertca
2016-08-06 16:57:39cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)