Tryton - Issues

 

Issue5726

Title Remove default table_query method
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type performance Components trytond
Assigned To ced Keywords review
Reviews 47321002
View: 47321002

Created on 2016-07-18.04:07:55 by ced, last changed by roundup-bot.

Messages
New changeset d82b88073486 by C├ędric Krier in branch 'default':
Do not call table_query for testing
http://hg.tryton.org/trytond/rev/d82b88073486
review47321002 updated at https://codereview.tryton.org/47321002/#ps1
msg27177 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-07-18.04:07:54
ModelSQL.table_query has a definition which returns None by default. This means that to test if the ModelSQL has a table_query or not, the method must be called.
Some table_query could be quite expensive to compute, so it could be expensive to call it just to test if it does not return None. Instead I think we could define ModelSQL.table_query = None by default and just test the attribute.
History
Date User Action Args
2018-04-30 15:55:36roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg40473
2018-04-15 01:56:26reviewbotsetnosy: + reviewbot
messages: + msg40146
2018-04-15 01:43:29cedsetstatus: unread -> testing
reviews: 47321002
keyword: + review
assignedto: ced
2016-07-18 04:07:55cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)