Tryton - Issues

 

Issue5565

Title Compute party receivable/payable for account without party required
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type behavior Components account
Assigned To ced Keywords review
Reviews 50561002
View: 50561002

Created on 2016-05-21.08:50:57 by ced, last changed by roundup-bot.

Messages
New changeset 9e8116f7ff26 by Cédric Krier in branch 'default':
Enforce party required on account receivable and payable
https://hg.tryton.org/tryton-env/rev/9e8116f7ff26
New changeset 8c42288a445a by Cédric Krier in branch 'default':
Enforce party required on account receivable and payable
https://hg.tryton.org/modules/account/rev/8c42288a445a
review50561002 updated at https://codereview.tryton.org/50561002/#ps60001
review50561002 updated at https://codereview.tryton.org/50561002/#ps40001
review50561002 updated at https://codereview.tryton.org/50561002/#ps20001
msg43752 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-09-06.23:04:28
Such query would require to make an extra join on party.party.account and use a coalesce for the where clause. This will make the query much more slower and difficult to optimize with indexes.
So I think it is better to make it party_required required for those accounts (which is probably already set on all installations).
msg25917 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-05-21.08:50:56
The method to compute the sum uses a SQL query that filter lines on party. But users could have a setup where they create one account per party and they don't set party required on the account. This result of having receivable/payable lines without party set.
I think the method should add the balance of the linked account if it does not have party required set.
History
Date User Action Args
2018-09-11 00:20:21roundup-botsetmessages: + msg43806
2018-09-11 00:20:08roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg43803
2018-09-07 15:54:27reviewbotsetmessages: + msg43761
2018-09-07 00:31:32reviewbotsetmessages: + msg43754
2018-09-06 23:27:26reviewbotsetnosy: + reviewbot
messages: + msg43753
2018-09-06 23:06:30cedsetstatus: in-progress -> testing
reviews: 50561002
keyword: + review
2018-09-06 23:04:29cedsetmessages: + msg43752
2018-09-06 23:01:30cedsetstatus: unread -> in-progress
assignedto: ced
2018-04-24 11:11:52cedsetpriority: feature -> bug
2016-05-21 08:51:44cedsetpriority: bug -> feature

Showing 10 items. Show all history (warning: this could be VERY long)