Tryton - Issues

 

Issue5454

Title Better integer test on ModelStorage instantiation
Priority feature Status testing
Superseder Nosy List JonLevy, ced
Type behavior Components trytond
Assigned To JonLevy Keywords easy, review
Reviews 24111002
View: 24111002

Created on 2016-04-02.11:01:14 by ced, last changed by udono.

Messages
msg25404 (view) Author: [hidden] (JonLevy) Date: 2016-04-03.21:24:42
Proof of concept for the second error type ("assert id in _ids") at review24111002.
msg25388 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-04-02.11:01:13
The test done at [1] is not really reliable because some other values than integer could pass it like a string with an integer or a float. Of course it will fail after but it will be more obscure issue see [2].

[1] http://hg.tryton.org/trytond/file/9594dc72ebe3/trytond/model/modelstorage.py#l1173
[2] https://groups.google.com/d/topic/tryton/4EB9PB2-hzM/discussion
History
Date User Action Args
2019-08-22 16:19:16udonosetstatus: chatting -> testing
assignedto: JonLevy
2016-04-03 21:30:09reviewbotsetreviews: 24111002
keyword: + review
2016-04-03 21:24:43JonLevysetstatus: unread -> chatting
nosy: + JonLevy
messages: + msg25404
2016-04-02 12:30:33cedsetkeyword: + easy
2016-04-02 11:01:15cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)