Created on 2016-03-03.09:49:42 by ced, last changed 63 months ago by roundup-bot.
New changeset 5a5016ab2b3d by Shreedhar Manek in branch 'default': Move tax_rounding from account_invoice module to account module http://hg.tryton.org/modules/account_invoice/rev/5a5016ab2b3d
New changeset a958bbb8389d by Shreedhar Manek in branch 'default': Move tax_rounding configuration from account_invoice to account module http://hg.tryton.org/modules/account/rev/a958bbb8389d
Added review for account_invoice module
@ced I see! I'll get used to the terminology soon!
On 2016-03-17 11:31, Shreedhar Manek wrote: > @ced okay, I'll do that. I asked kstenger if it was okay to add it to the same issue and she said that it was because they were related modules. She talked about issue on the bugtracker. We use the term of review on codereview.tryton.org
@ced okay, I'll do that. I asked kstenger if it was okay to add it to the same issue and she said that it was because they were related modules.
@shrox you must create a separate review for account_invoice
Please try to submit both reviews in the same time, it will be easier to review.
Submitted path for review after rectifications from first review.
It will be good to have it fixed before the release freeze at the 28th March.
I will continue with this work after 3 days. My mid semester exams in college now. Will definitively resolve this and other bugs soon.
Changing status to 'testing'
We are missing the review for account_invoice.
@shrox Don't forget to drop a message when you submit a review and set the status to testing.
Since r f57cb6b80d9d, the tax_rounding configuration is used in the module account and no more in account_invoice so the configuration should be moved from account_invoice to account module.
|2016-03-25 10:32:14||roundup-bot||set||messages: + msg25250|
|2016-03-25 10:31:33||roundup-bot||set||status: testing -> resolved|
nosy: + roundup-bot
messages: + msg25249
|2016-03-17 13:00:11||reviewbot||set||reviews: 20851002 -> 20851002, 20871002|
|2016-03-17 12:58:07||shrox||set||messages: + msg25113|
|2016-03-17 12:37:28||shrox||set||reviews: 20851002 20871002 -> 20851002|
|2016-03-17 12:36:59||shrox||set||reviews: 20851002 -> 20851002 20871002|
messages: + msg25112
|2016-03-17 12:31:17||shrox||set||messages: + msg25111|
|2016-03-17 12:05:34||ced||set||messages: + msg25110|
|2016-03-17 11:31:48||shrox||set||messages: + msg25109|
|2016-03-17 10:10:39||ced||set||messages: + msg25108|
Showing 10 items. Show all history (warning: this could be VERY long)