Tryton - Issues

 

Issue5191

Title depends method across on_change and on_change_with
Priority feature Status testing
Superseder Nosy List ced, pokoli, reviewbot
Type feature request Components trytond
Assigned To ced Keywords review
Reviews 50381002, 48341002, 47431002, 45481002, 50371003, 46441002, 45491002, 38251002, 45131002, 49341002
View: 50381002, 48341002, 47431002, 45481002, 50371003, 46441002, 45491002, 38251002, 45131002, 49341002

Created on 2015-12-18.15:10:33 by ced, last changed by reviewbot.

Messages
review45131002 updated at https://codereview.tryton.org/45131002/#ps20001
New review49341002 at https://codereview.tryton.org/49341002/#ps1
New review45131002 at https://codereview.tryton.org/45131002/#ps1
New review38251002 at https://codereview.tryton.org/38251002/#ps1
New review45491002 at https://codereview.tryton.org/45491002/#ps1
New review46441002 at https://codereview.tryton.org/46441002/#ps1
New review50371003 at https://codereview.tryton.org/50371003/#ps1
New review45481002 at https://codereview.tryton.org/45481002/#ps1
New review47431002 at https://codereview.tryton.org/47431002/#ps1
New review48341002 at https://codereview.tryton.org/48341002/#ps1
New review50381002 at https://codereview.tryton.org/50381002/#ps1
msg40594 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-05-09.10:42:27
Indeed it will be even better to be able to use the depends of any function instead of limiting to on_change's.
msg23395 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2015-12-18.15:10:32
For now, the depends methods can only work with the same kind of method so if inside an on_change we want to call an on_change_with, it doesn't work.
It is OK for most of the kind of depending function, except for on_change and on_change_with because indeed they are from the same family.
I think the ModelView.__setup__ should takes the depends of both kinds.
History
Date User Action Args
2018-05-22 15:20:25reviewbotsetmessages: + msg40934
2018-05-17 18:38:40reviewbotsetmessages: + msg40748
2018-05-17 18:38:39reviewbotsetreviews: 50381002, 48341002, 47431002, 45481002, 50371003, 46441002, 45491002, 38251002, 45131002 -> 50381002, 48341002, 47431002, 45481002, 50371003, 46441002, 45491002, 38251002, 45131002, 49341002
2018-05-17 18:38:35reviewbotsetmessages: + msg40747
2018-05-17 18:38:34reviewbotsetreviews: 50381002, 48341002, 47431002, 45481002, 50371003, 46441002, 45491002, 38251002 -> 50381002, 48341002, 47431002, 45481002, 50371003, 46441002, 45491002, 38251002, 45131002
2018-05-17 18:18:26cedsetstatus: in-progress -> testing
2018-05-17 18:18:09reviewbotsetmessages: + msg40744
2018-05-17 18:18:08reviewbotsetreviews: 50381002, 48341002, 47431002, 45481002, 50371003, 46441002, 45491002 -> 50381002, 48341002, 47431002, 45481002, 50371003, 46441002, 45491002, 38251002
2018-05-17 18:18:05reviewbotsetmessages: + msg40743
2018-05-17 18:18:04reviewbotsetreviews: 50381002, 48341002, 47431002, 45481002, 50371003, 46441002 -> 50381002, 48341002, 47431002, 45481002, 50371003, 46441002, 45491002

Showing 10 items. Show all history (warning: this could be VERY long)