Tryton - Issues

 

Issue2647

Title Missing implementation of drop_column for SQLite
Priority bug Status resolved
Superseder Nosy List ced, mrichez, reviewbot, roundup-bot
Type behavior Components trytond
Assigned To mrichez Keywords review
Reviews 30311002
View: 30311002

Created on 2012-06-12.09:43:47 by ced, last changed by roundup-bot.

Messages
msg27906 (view) Author: [hidden] (roundup-bot) Date: 2016-08-23.17:35:04
New changeset a3ef75ef8f6a by Maxime Richez in branch 'default':
Add missing implementation of drop_column for SQLite
http://hg.tryton.org/trytond/rev/a3ef75ef8f6a
msg27905 (view) Author: [hidden] (reviewbot) Date: 2016-08-23.17:21:57
review30311002 updated at https://codereview.tryton.org/30311002/#ps120001
msg27801 (view) Author: [hidden] (reviewbot) Date: 2016-08-19.16:15:21
review30311002 updated at https://codereview.tryton.org/30311002/#ps100001
msg27769 (view) Author: [hidden] (reviewbot) Date: 2016-08-17.16:19:39
review30311002 updated at https://codereview.tryton.org/30311002/#ps80001
msg27245 (view) Author: [hidden] (reviewbot) Date: 2016-07-20.09:00:21
review30311002 updated at https://codereview.tryton.org/30311002/#ps60001
msg27100 (view) Author: [hidden] (reviewbot) Date: 2016-07-15.11:30:17
review30311002 updated at https://codereview.tryton.org/30311002/#ps40001
msg27057 (view) Author: [hidden] (reviewbot) Date: 2016-07-13.14:30:19
review30311002 updated at https://codereview.tryton.org/30311002/#ps20001
msg27049 (view) Author: [hidden] (reviewbot) Date: 2016-07-13.11:30:17
New review30311002 at https://codereview.tryton.org/30311002/#ps1
msg10983 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2012-06-12.09:43:46
Some migration code are based on the assumption that the column will be dropped
when the code is run a second times.
The drop_column [1] should be implemented the same way as column_rename [2]

[1]
http://hg.tryton.org/trytond/file/9a2e382df2f8/trytond/backend/sqlite/table.py#l301
[2]
http://hg.tryton.org/trytond/file/9a2e382df2f8/trytond/backend/sqlite/table.py#l91
History
Date User Action Args
2016-08-23 17:35:04roundup-botsetstatus: in-progress -> resolved
nosy: + roundup-bot
messages: + msg27906
2016-08-23 17:21:57reviewbotsetmessages: + msg27905
2016-08-19 16:15:21reviewbotsetmessages: + msg27801
2016-08-17 16:19:39reviewbotsetmessages: + msg27769
2016-07-20 09:00:21reviewbotsetmessages: + msg27245
2016-07-15 11:30:18reviewbotsetmessages: + msg27100
2016-07-13 14:30:19reviewbotsetmessages: + msg27057
2016-07-13 11:30:18reviewbotsetnosy: + reviewbot
messages: + msg27049
2016-07-13 11:30:15reviewbotsetreviews: 30311002
keyword: + review
2016-07-13 11:24:56mrichezsetassignedto: mrichez

Showing 10 items. Show all history (warning: this could be VERY long)