Tryton - Issues

 

Issue2172

Title product field is required when creating sale lines in module sale_opportunity
Priority feature Status testing
Superseder Nosy List lukio, nicoe, reviewbot, sharoon
Type behavior Components sale_opportunity
Assigned To lukio Keywords easy, review
Reviews 30651002
View: 30651002

Created on 2011-10-05.18:07:25 by nicoe, last changed by reviewbot.

Messages
review30651002 updated at https://codereview.tryton.org/30651002/#ps20001
msg29535 (view) Author: [hidden] (lukio) Date: 2016-10-20.17:05:36
I also add the unit_price field, because if the product doesn't exists, that field is required at sale line.
New review30651002 at https://codereview.tryton.org/30651002/#ps1
msg29521 (view) Author: [hidden] (nicoe) (Tryton committer) (Tryton translator) Date: 2016-10-20.14:59:35
I think so too.
msg29446 (view) Author: [hidden] (lukio) Date: 2016-10-20.08:17:02
Hi, I think hat if product it's not gonna be required any more, we shoud add a descrption field like SaleLine on sale module.
msg29441 (view) Author: [hidden] (lukio) Date: 2016-10-19.19:18:21
Working on a patch.
msg8817 (view) Author: [hidden] (nicoe) (Tryton committer) (Tryton translator) Date: 2011-10-05.18:07:25
The product field is required in the sale line of the sale_opportunity
module.
But this field is not required in the sale module.
I think that this field should not be required.
History
Date User Action Args
2016-10-20 18:55:27reviewbotsetmessages: + msg29546
2016-10-20 17:05:36lukiosetmessages: + msg29535
2016-10-20 17:04:36lukiosetstatus: in-progress -> testing
2016-10-20 16:53:42reviewbotsetnosy: + reviewbot
messages: + msg29534
2016-10-20 16:53:42reviewbotsetreviews: 30651002
keyword: + review
2016-10-20 14:59:35nicoesetmessages: + msg29521
2016-10-20 08:17:02lukiosetmessages: + msg29446
2016-10-20 08:14:37lukiosetcomponent: + sale_opportunity
2016-10-19 19:18:21lukiosetmessages: + msg29441
2016-10-19 19:18:08lukiosetstatus: unread -> in-progress
assignedto: lukio
nosy: + lukio

Showing 10 items. Show all history (warning: this could be VERY long)