I updated the review376391002 to show that we could compute the cumulate in the get_balance of Deferral.

I still do not uderstand why the code can not be placed in get_balance.

Then we do not understand each other.

On my first attempt I tried to follow your advice and make the get_balance sum the children accounts, but this does not fix the issue because it does not exist any deferral record related to the parent account, so the cumulate function does not find it so the children sum in get_balance is useless.

I do not understand why it can not be done in the Deferral.get_balance.

Because we do not create a deferral record for accounts that do not have any type. So the search of the deferral records fails for parent accounts.

Indeed the same code could be written in this function if it is changed
into a classmethod.

This requires to have a deferral record for all accounts which is not the case.

Here is review376391002 which cumulates the children amounts on balance.
It is not possible to do it on the deferral computation as the parent accounts does not have any deferral record, but we can include the children account values on the _cumulate function for balance.

For me it is the wrong solution msg72549 because the deferrals are also used to compute debit and credit which are not summing children.
Indeed I think the proper solution is that get_balance of Account Deferral should sum the children.

For the record, on newsletter or where you consider we should warn to reopen and close the fiscal years to recompute.

Don't know since this happens, but at least we found on 6.0 and following so it should be backported.

The issue comes from the credit/debit computation which does not compute values for parent accounts. The computation is done on the balance (thanks to parent left/right).

To have a proper computation we need to store such values, so I guess we can add a context flag to enable computation also for parents records and activate it on the BalanceNonDeferral computation.

If a equity account (A) have sub-accounts/childs (A.1) on closing the fiscal year it doesn't store the debit/credit of A, causing wrong computation of the balance.
I don't know if maybe it's normal that A is not saved instead balance of A should return the childs sum.
The steps could be reproduced by the attached scenario.
I'm starting to check where the problem could be.
Any help is appreciated as account module and accounting in general could be complex.