Issue 11030

Title
Concurrent update in sao's wizard could result in incoherent behaviour
Priority
bug
Status
resolved
Nosy list
ced, nicoe, reviewbot, roundup-bot
Assigned to
nicoe
Keywords
review

Created on 2021-12-09.09:36:55 by nicoe, last changed 7 months ago by roundup-bot.

Messages

New changeset 1fa900154756 by Nicolas Évrard in branch '6.2':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/1fa900154756

New changeset d9b1352a9a5b by Nicolas Évrard in branch '6.0':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/d9b1352a9a5b

New changeset 5c064d99853e by Nicolas Évrard in branch '5.0':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/5c064d99853e
New changeset c80be611a16f by Nicolas Évrard in branch 'default':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/tryton-env/rev/c80be611a16f
New changeset 4585dcb48a1a by Nicolas Évrard in branch 'default':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/4585dcb48a1a
Author: [hidden] (nicoe) Tryton committer
Date: 2021-12-09.09:59:16
* Cédric Krier  [2021-12-09 09:40 +0100]: 
>
>Cédric Krier <cedric.krier@b2ck.com> added the comment:
>
>On 2021-12-09 09:36, Nicolas Évrard wrote:
>> Since setting the value of another might trigger an RPC call
>
>I do not understand what this means ?

It should be "Since setting the value of another *field*".

Setting values in the default might trigger an on_change or on_change_with RPC
call.
Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-12-09.09:40:51
On 2021-12-09 09:36, Nicolas Évrard wrote:
> Since setting the value of another might trigger an RPC call

I do not understand what this means ?
Author: [hidden] (nicoe) Tryton committer
Date: 2021-12-09.09:36:54

In sao when a StateView is sent to the wizard, we're setting the values of the form with a call to set_default.
When the value of a M2O is set it could happen that its rec_name is not sent thus it requires to make an RPC call in order to get it.

Since setting the value of another might trigger an RPC call we now have two concurrent RPC call. According to the order in which they will be treated the value of the M2O could be different. I think the behaviour should be always the same.

The review fixes that.

History
Date User Action Args
2022-02-26 11:48:50roundup-botsetkeyword: - backport
messages: + msg74357
2022-02-08 18:55:42roundup-botsetmessages: + msg73969
2022-02-08 18:55:39roundup-botsetmessages: + msg73968
nosy: + roundup-bot
status: testing -> resolved
2022-01-21 14:31:38cedsetkeyword: + backport
status: chatting -> testing
2022-01-21 11:15:54reviewbotsetmessages: + msg73372
2022-01-19 17:51:20reviewbotsetmessages: + msg73322
2021-12-09 09:59:16nicoesetmessages: + msg72063
2021-12-09 09:54:36reviewbotsetmessages: + msg72062
nosy: + reviewbot
2021-12-09 09:40:52cedsetmessages: + msg72058
nosy: + ced
status: unread -> chatting
2021-12-09 09:36:55nicoecreate

Showing 10 items. Show all history (warning: this could be VERY long)