Issue 10714

Title
Missing sepa identifer message not show
Priority
bug
Status
testing
Nosy list
pokoli, reviewbot
Assigned to
pokoli
Keywords
backport, review

Created on 2021-09-03.12:13:26 by pokoli, last changed 1 month ago by reviewbot.

Messages

Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2021-09-03.12:15:37

Here is review336861002 which fixes it.
This was introduce by rev f8a3b95009da

Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2021-09-03.12:13:26

When creating a payment group with an identifier type that the party is missing the following error is show:

Traceback (most recent call last):
  File "/trytond/wsgi.py", line 117, in dispatch_request
    return endpoint(request, **request.view_args)
  File "/trytond/protocols/dispatcher.py", line 47, in rpc
    return methods.get(request.rpc_method, _dispatch)(
  File "/trytond/wsgi.py", line 84, in auth_required
    return wrapped(*args, **kwargs)
  File "/trytond/protocols/wrappers.py", line 156, in wrapper
    return func(request, pool, *args, **kwargs)
  File "/trytond/protocols/dispatcher.py", line 181, in _dispatch
    result = rpc.result(meth(*c_args, **c_kwargs))
  File "/trytond/wizard/wizard.py", line 314, in execute
    return wizard._execute(state_name)
  File "/trytond/wizard/wizard.py", line 340, in _execute
    do_result = do(action)
  File "/trytond/modules/account_payment/payment.py", line 572, in do_process
    Payment.process(list(grouped_payments), group)
  File "/trytond/model/workflow.py", line 37, in wrapper
    result = func(cls, filtered, *args, **kwargs)
  File "/trytond/modules/account_payment/payment.py", line 501, in process
    process_method(group)
  File "/trytond/modules/account_payment_sepa/payment.py", line 231, in process_sepa
    self.generate_message(_save=False)
  File "/trytond/model/descriptors.py", line 31, in newfunc
    return self.func(owner, [instance], *args, **kwargs)
  File "/trytond/model/modelview.py", line 774, in wrapper
    return func(cls, records, *args, **kwargs)
  File "/trytond/modules/account_payment_sepa/payment.py", line 244, in generate_message
    message = tmpl.generate(group=group,
  File "/genshi/core.py", line 183, in render
    return encode(generator, method=method, encoding=encoding, out=out)
  File "/genshi/output.py", line 59, in encode
    return _encode(''.join(list(iterator)))
  File "/genshi/output.py", line 243, in __call__
    for kind, data, pos in stream:
  File "/genshi/output.py", line 674, in __call__
    for kind, data, pos in stream:
  File "/genshi/output.py", line 779, in __call__
    for kind, data, pos in chain(stream, [(None, None, None)]):
  File "/genshi/output.py", line 598, in __call__
    for ev in stream:
  File "/genshi/core.py", line 291, in _ensure
    for event in stream:
  File "/genshi/core.py", line 291, in _ensure
    for event in stream:
  File "/trytond/modules/account_payment_sepa/payment.py", line 173, in remove_comment
    for kind, data, pos in stream:
  File "/genshi/template/base.py", line 641, in _include
    for event in stream:
  File "/genshi/template/markup.py", line 326, in _match
    for event in stream:
  File "/genshi/template/base.py", line 581, in _flatten
    for kind, data, pos in stream:
  File "/genshi/template/directives.py", line 728, in __call__
    value = _eval_expr(expr, ctxt, vars)
  File "/genshi/template/base.py", line 291, in _eval_expr
    retval = expr.evaluate(ctxt)
  File "/genshi/template/eval.py", line 160, in evaluate
    return eval(self.code, _globals, {'__data__': data})
  File "/trytond/modules/account_payment_sepa/template/base.xml", line 14, in <Expression '?'>
    <py:with vars="identifier = party.get_sepa_identifier(id)">
  File "/trytond/modules/account_payment_sepa/party.py", line 68, in get_sepa_identifier
    type = dict(selection).get(name)
ValueError: dictionary update sequence element #0 has length 1; 2 is required

Fault: dictionary update sequence element #0 has length 1; 2 is required

I will expect that the proper error message is shown.

History
Date User Action Args
2021-09-03 12:31:48reviewbotsetmessages: + msg69851
nosy: + reviewbot
2021-09-03 12:15:37pokolisetkeyword: + backport, review
messages: + msg69850
reviews: 336861002
status: in-progress -> testing
2021-09-03 12:13:26pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)