Created on 2021-06-11.18:38:11 by nicoe, last changed 3 weeks ago by reviewbot.
I'm in favor of doing less because less code -> less bug, customizer can not undo that easily and history keeping.
* Cédric Krier [2021-06-12 00:15 +0200]: > >Cédric Krier <email@example.com> added the comment: > >I'm not fully sure that we must remove the lines as payment lines. Indeed the >lines will be reconciled so they will be ignored. But in case the user made a >mistake and cancel the cancellation move, the link will be lost. I am not sure either. When I first encountered a bug related to this I thought the payment lines where copied on purpose but after our discussion since we talked about removing the lines it seems logical moreover because when another line will pay the invoice the original lines will be removed anyway. So yeah, I don't know if it's better to keep the trace or to hide the details of a move that is canceled.
I'm not fully sure that we must remove the lines as payment lines. Indeed the lines will be reconciled so they will be ignored. But in case the user made a mistake and cancel the cancellation move, the link will be lost.
When canceling the paying move of an invoice a new move is created with a line canceling the paying line of the invoice.
This line will be referenced in the payment lines of the invoice.
This is due to the fact that canceling an account move is basically duplicating the move with the credit / debit amount inverted. Thus in copy process the link to the invoice is also copied.
So we should not copy the link and remove the link of the canceled move.
|2021-09-21 15:57:29||reviewbot||set||messages: + msg70248|
|2021-06-14 15:36:06||reviewbot||set||messages: + msg68244|
|2021-06-12 09:06:27||ced||set||messages: + msg68226|
|2021-06-12 09:03:23||nicoe||set||messages: + msg68224|
nosy: + ced
nosy: + reviewbot
Showing 10 items. Show all history (warning: this could be VERY long)