Issue 10502

Title
Cancelling the account move paying an invoice adds the cancelling line to the payment lines of the invoice
Priority
bug
Status
in-progress
Nosy list
ced, nicoe, reviewbot
Assigned to
nicoe
Keywords
review

Created on 2021-06-11.18:38:11 by nicoe, last changed 1 month ago by reviewbot.

Messages

Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-06-12.09:06:27

I'm in favor of doing less because less code -> less bug, customizer can not undo that easily and history keeping.

Author: [hidden] (nicoe) Tryton committer
Date: 2021-06-12.09:03:22
* Cédric Krier  [2021-06-12 00:15 +0200]: 
>
>Cédric Krier <cedric.krier@b2ck.com> added the comment:
>
>I'm not fully sure that we must remove the lines as payment lines. Indeed the
>lines will be reconciled so they will be ignored. But in case the user made a
>mistake and cancel the cancellation move, the link will be lost.

I am not sure either. When I first encountered a bug related to this I thought
the payment lines where copied on purpose but after our discussion since we
talked about removing the lines it seems logical moreover because when another
line will pay the invoice the original lines will be removed anyway.

So yeah, I don't know if it's better to keep the trace or to hide the details
of a move that is canceled.
Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-06-12.00:15:05

I'm not fully sure that we must remove the lines as payment lines. Indeed the lines will be reconciled so they will be ignored. But in case the user made a mistake and cancel the cancellation move, the link will be lost.

Author: [hidden] (nicoe) Tryton committer
Date: 2021-06-11.18:38:10

When canceling the paying move of an invoice a new move is created with a line canceling the paying line of the invoice.
This line will be referenced in the payment lines of the invoice.

This is due to the fact that canceling an account move is basically duplicating the move with the credit / debit amount inverted. Thus in copy process the link to the invoice is also copied.

So we should not copy the link and remove the link of the canceled move.

History
Date User Action Args
2021-06-14 15:36:06reviewbotsetmessages: + msg68244
2021-06-12 09:06:27cedsetmessages: + msg68226
2021-06-12 09:03:23nicoesetmessages: + msg68224
2021-06-12 00:15:05cedsetmessages: + msg68223
nosy: + ced
2021-06-11 19:05:34reviewbotsetmessages: + msg68222
nosy: + reviewbot
2021-06-11 18:38:11nicoecreate

Showing 10 items. Show all history (warning: this could be VERY long)