Issue 10380

Title
Cache removing context keys modify global context
Priority
bug
Status
resolved
Nosy list
ced, coogor, reviewbot, roundup-bot
Assigned to
ced
Keywords
review

Created on 2021-05-03.14:22:33 by ced, last changed yesterday by roundup-bot.

Messages

New changeset 6ee56344a23f by Cédric Krier in branch '6.0':
Pop cache keys from a copy of the context
https://hg.tryton.org/trytond/rev/6ee56344a23f

New changeset b009b7d587f5 by Cédric Krier in branch '5.8':
Pop cache keys from a copy of the context
https://hg.tryton.org/trytond/rev/b009b7d587f5

New changeset d20478d9522f by Cédric Krier in branch '5.6':
Pop cache keys from a copy of the context
https://hg.tryton.org/trytond/rev/d20478d9522f

New changeset bfcc5566fb1e by Cédric Krier in branch '5.0':
Pop cache keys from a copy of the context
https://hg.tryton.org/trytond/rev/bfcc5566fb1e
New changeset 0ff499f05a4a by Cédric Krier in branch 'default':
Pop cache keys from a copy of the context
https://hg.tryton.org/tryton-env/rev/0ff499f05a4a
New changeset b0a5d11ac400 by Cédric Krier in branch 'default':
Pop cache keys from a copy of the context
https://hg.tryton.org/trytond/rev/b0a5d11ac400
Author: [hidden] (coogor)
Date: 2021-05-03.21:44:13

looks like your 'solution' is exactly that was proposed in https://codereview.tryton.org/351911002/#msg10

It is good practice in the OpenSource world to give Kudos to those, who contribute, and not to sell it as own work

Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-05-03.14:22:33

Since rev 09751b1d7f91, the Cache pop keys from the context but it should do it on a copy otherwise it modifies the context for the all transaction.

History
Date User Action Args
2021-05-07 00:06:34roundup-botsetkeyword: - backport
messages: + msg67464
2021-05-05 23:13:21roundup-botsetmessages: + msg67391
2021-05-05 23:13:12roundup-botsetmessages: + msg67390
nosy: + roundup-bot
status: testing -> resolved
2021-05-03 21:44:13coogorsetmessages: + msg67347
nosy: + coogor
2021-05-03 14:51:43reviewbotsetmessages: + msg67339
nosy: + reviewbot
2021-05-03 14:24:09cedlinkissue10377 superseder
2021-05-03 14:23:57cedlinkissue10376 superseder
2021-05-03 14:23:39cedsetkeyword: + backport, review
reviews: 358061003
status: in-progress -> testing
2021-05-03 14:22:33cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)