Issue 10374

Use canonical domain for test comparison
Nosy list
ced, reviewbot, yangoon
Assigned to

Created on 2021-04-30.14:23:31 by ced, last changed 18 months ago by ced.


Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-05-16.18:17:18

review358021002 has been included by mistake in rev 801d153ef88d

Author: [hidden] (yangoon) Tryton translator
Date: 2021-04-30.18:02:28

Wouldn't it be more adequate to deprecate Python < 3.6 ?

The test says anyway: "Python 3.5 reached the end of its life on September 13th, 2020. Please upgrade your Python as Python 3.5 is no longer maintained. pip 21.0 will drop support for Python 3.5 in January 2021. pip 21.0 will remove support for this functionality."

Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-04-30.14:31:06

Here is the temporary disabling: review358021002

Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-04-30.14:23:31

The build shows that comparing generated domain is wrong because it relies on the internal implementation.
We need a tool to canonize a domain by simplifying it and ordering its content.

Meanwhile I propose to skip this test for version < 3.6.

Date User Action Args
2021-05-16 18:17:23cedsetkeyword: - review
2021-05-16 18:17:18cedsetmessages: + msg67617
2021-04-30 18:02:28yangoonsetmessages: + msg67130
nosy: + yangoon
2021-04-30 14:44:29reviewbotsetmessages: + msg67129
nosy: + reviewbot
status: unread -> chatting
2021-04-30 14:31:06cedsetkeyword: + review
messages: + msg67128
reviews: 358021002
2021-04-30 14:23:31cedcreate