Issue 10162

Title
Review usage of get_multivalue and set_multivalue
Priority
feature
Status
resolved
Superseder
Add company to package (issue 10197)
Project-Id-Version: Roundup 0.7.0 Report-Msgid-Bugs-To: roundup-devel@lists.sourceforge.net POT-Creation-Date: 2021-07-12 22:10-0400 PO-Revision-Date: 2004-11-20 13:47+0200 Language-Team: English Language: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii
Add company to reconciliation (issue 10195)
Nosy list
albertca, ced, reviewbot, roundup-bot
Assigned to
ced
Keywords
review

Created on 2021-03-05.17:08:04 by ced, last changed 20 months ago by roundup-bot.

Messages

New changeset a8fde6aa371e by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/tryton-env/rev/a8fde6aa371e
New changeset 345598557263 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/web_shop/rev/345598557263
New changeset 4d1a9fca738a by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/stock_supply/rev/4d1a9fca738a
New changeset 7433097e2289 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/stock_package/rev/7433097e2289
New changeset eb0ceb50055d by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/stock/rev/eb0ceb50055d
New changeset 6477e81fc995 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/sale_supply_drop_shipment/rev/6477e81fc995
New changeset 26ebc184c1f4 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/sale_subscription/rev/26ebc184c1f4
New changeset f8bc12cd901d by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/sale_shipment_tolerance/rev/f8bc12cd901d
New changeset a7bacda79965 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/sale_shipment_cost/rev/a7bacda79965
New changeset a978c657c35b by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/sale_price_list/rev/a978c657c35b
New changeset 05a9bccad127 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/sale_opportunity/rev/05a9bccad127
New changeset 27fdcf6bc98b by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/sale_complaint/rev/27fdcf6bc98b
New changeset 9e3250c18038 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/sale/rev/9e3250c18038
New changeset 9d273c4bca09 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/purchase_requisition/rev/9d273c4bca09
New changeset 6a49e2943a86 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/purchase_request_quotation/rev/6a49e2943a86
New changeset a53f6da2680d by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/purchase/rev/a53f6da2680d
New changeset 23c2a8170f3b by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/project_invoice/rev/23c2a8170f3b
New changeset 3c4277687e29 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/production/rev/3c4277687e29
New changeset 716f73dd4fab by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/account_stock_landed_cost/rev/716f73dd4fab
New changeset 392aa31ee3df by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/account_stock_continental/rev/392aa31ee3df
New changeset 1a7b0f7f296f by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/account_payment_sepa/rev/1a7b0f7f296f
New changeset d899297caed7 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/account_payment/rev/d899297caed7
New changeset f73cfaad3dac by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/account_invoice/rev/f73cfaad3dac
New changeset 0e3563e79331 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/account_dunning_email/rev/0e3563e79331
New changeset 8091a4f746f6 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/account_dunning/rev/8091a4f746f6
New changeset 0b476210fc98 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/account_cash_rounding/rev/0b476210fc98
New changeset c7aec99ccd1c by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/account_asset/rev/c7aec99ccd1c
New changeset e0bd13f81f96 by Cédric Krier in branch 'default':
Add company pattern to multivalue calls
https://hg.tryton.org/modules/account/rev/e0bd13f81f96
Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-03-05.17:08:04

The usage of such method should follow some rules in order to work correctly for issue4080.

  • default_ methods must use get_multivalue but with pattern as keyword argument and they must have an on_change_ method for the depending pattern (ex: on_change_company) to set new default.
  • *_used property may call get_multivalue but we must set the right context
  • get_purchase_unit_price, get_sale_unit_price and get_context_formula are exceptions that can use get_multivalue

There should be no other use cases.

set_multivalue should almost never be used (except to update the product cost) as multivalue is for referential document and they should be updated only by users.

History
Date User Action Args
2021-04-03 14:29:39roundup-botsetmessages: + msg66047
2021-04-03 14:29:36roundup-botsetmessages: + msg66046
2021-04-03 14:29:32roundup-botsetmessages: + msg66045
2021-04-03 14:29:29roundup-botsetmessages: + msg66044
2021-04-03 14:29:27roundup-botsetmessages: + msg66043
2021-04-03 14:29:24roundup-botsetmessages: + msg66042
2021-04-03 14:29:21roundup-botsetmessages: + msg66041
2021-04-03 14:29:19roundup-botsetmessages: + msg66040
2021-04-03 14:29:16roundup-botsetmessages: + msg66039
2021-04-03 14:29:05roundup-botsetmessages: + msg66038

Showing 10 items. Show all history (warning: this could be VERY long)