Issue 10083

Title
Base64Converter to_url must return a string
Priority
bug
Status
resolved
Nosy list
ced, reviewbot, roundup-bot
Assigned to
ced
Keywords
review

Created on 2021-02-10.23:36:38 by ced, last changed 2 months ago by roundup-bot.

Messages

New changeset 55eba065c962 by Cédric Krier in branch '5.8':
Return string on Base64Converter.to_url
https://hg.tryton.org/trytond/rev/55eba065c962

New changeset a0ee5abfd764 by Cédric Krier in branch '5.6':
Return string on Base64Converter.to_url
https://hg.tryton.org/trytond/rev/a0ee5abfd764
New changeset c2b5639a939a by Cédric Krier in branch '5.8':
Return string on Base64Converter.to_url
https://hg.tryton.org/modules/web_shortener/rev/c2b5639a939a

New changeset 01b452326be5 by Cédric Krier in branch '5.6':
Return string on Base64Converter.to_url
https://hg.tryton.org/modules/web_shortener/rev/01b452326be5
New changeset 7b264869f6fd by Cédric Krier in branch '5.8':
Return string on Base64Converter.to_url
https://hg.tryton.org/modules/marketing_automation/rev/7b264869f6fd

New changeset 5fd1bae1a665 by Cédric Krier in branch '5.6':
Return string on Base64Converter.to_url
https://hg.tryton.org/modules/marketing_automation/rev/5fd1bae1a665
New changeset f6dfbf01c367 by Cédric Krier in branch 'default':
Return string on Base64Converter.to_url
https://hg.tryton.org/tryton-env/rev/f6dfbf01c367
New changeset b00d30820a9e by Cédric Krier in branch 'default':
Return string on Base64Converter.to_url
https://hg.tryton.org/trytond/rev/b00d30820a9e
New changeset 2808f871161d by Cédric Krier in branch 'default':
Return string on Base64Converter.to_url
https://hg.tryton.org/modules/web_shortener/rev/2808f871161d
New changeset c37b882a8247 by Cédric Krier in branch 'default':
Return string on Base64Converter.to_url
https://hg.tryton.org/modules/marketing_automation/rev/c37b882a8247
Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-02-10.23:36:38

According to the documentation <code>to_url</code> must return a string (not bytes).
I got exception when werkzeug matches an URL using this converter.

History
Date User Action Args
2021-02-24 21:25:55roundup-botsetmessages: + msg64842
2021-02-24 21:25:22roundup-botsetmessages: + msg64836
2021-02-24 21:24:10roundup-botsetkeyword: - backport
messages: + msg64829
2021-02-14 15:54:55roundup-botsetmessages: + msg64577
2021-02-14 15:54:53roundup-botsetmessages: + msg64576
2021-02-14 15:54:50roundup-botsetmessages: + msg64575
2021-02-14 15:54:47roundup-botsetmessages: + msg64574
nosy: + roundup-bot
status: testing -> resolved
2021-02-11 00:04:36reviewbotsetmessages: + msg64454
nosy: + reviewbot
2021-02-11 00:03:44cedlinkissue10085 superseder
2021-02-10 23:38:14cedsetkeyword: + backport, review
reviews: 353321002
status: in-progress -> testing

Showing 10 items. Show all history (warning: this could be VERY long)