Support of current eonasdan-bootstrap-datetimepicker
Current version of eonasdan-bootstrap-datetimepicker is 4.17.42.
This current version version works with
"dependencies": {
"jquery": "~2.1.1",
"bootstrap": "latest",
"moment": "latest",
"eonasdan-bootstrap-datetimepicker": "latest",
"gettext.js": "~0.5.0",
"d3": "~3.5.0",
"c3": "~0.4.10"
},
and adding something like the following stanza to index.html.
<div class="container">
<div class="row">
<div class='col-sm-6'>
<div class="form-group">
<div class='input-group date' id='datetimepicker1'>
<input type='text' class="form-control" size="10" />
<span class="input-group-addon">
<span class="glyphicon glyphicon-calendar"></span>
</span>
</div>
</div>
</div>
</div>
</div>
<script type="text/javascript">
jQuery(function() {
jQuery('[data-toggle="offcanvas"]').click(function() {
jQuery('.row-offcanvas').toggleClass('active');
});
jQuery('#tabs').on('ready', function() {
if (jQuery(this).find('> .nav-tabs').children().length) {
jQuery('.row-offcanvas').removeClass('active');
} else {
jQuery('.row-offcanvas').addClass('active');
}
});
Sao.login();
});
$(function () {
$('#datetimepicker1').datetimepicker();
});
</script>
</body>
Clicking on the additional control displays the widget, while it doesn't display when called from a Tryton form like the scheduler form.
Files
| Download | Creator | Timestamp | Type |
|---|---|---|---|
| upgrade_datepicker.diff | @pokoli | 2016-09-09 07:31:29.491000 UTC | text/plain |
Activity
added sao + 1 deleted label
We are waiting for #5796 (closed) to be resolved to upstream to see if we can upgrade to a newer version which includes the proposed PR.
BTW: have you found another bug which requires the upgrade?
Also with your proposed changes it will upgrade bootstrap and moment.js. So maybe al the dependencies should be upgraded.
In order to make sao datetimepicker work with latest version you must apply the attached patch on sao.added type::feature + 1 deleted label and removed 1 deleted label
> We are waiting for #5796 (closed) to be resolved to upstream to see if we can
> upgrade to a newer version which includes the proposed PR.
I see.
> BTW: have you found another bug which requires the upgrade?
No. My motivation is just to provide a working datepicker via Debian packages
and testing showed, that neither 4.17.37 nor 4.17.42 worked in sao.
> Also with your proposed changes it will upgrade bootstrap and moment.js. So
> maybe al the dependencies should be upgraded.
My intention with the dependency change was only to show, that with the
depicted scenario the datepicker works with latest bootstrap and moment.
Of course it would be nice to upgrade all deps to latest, but sao
currently doesn't work with jquery3 (stops at login screen after succesful
login) and the bugtracker of eonasdan-bootstrap-datetimepicker shows several
open issues related to jquery3. So I don't think the upgrade to jquery3 won't
be in the very near future?
> In order to make sao datetimepicker work with latest version you must apply
> the attached patch on sao.
Thanks, works!> Mathias Behrle <mbehrle@m9s.biz> added the comment:
>
>> BTW: have you found another bug which requires the upgrade?
>
> No. My motivation is just to provide a working datepicker via Debian packages
> and testing showed, that neither 4.17.37 nor 4.17.42 worked in sao.
You should use the same dependencies.
>
>> Also with your proposed changes it will upgrade bootstrap and moment.js. So
>> maybe al the dependencies should be upgraded.
>
> My intention with the dependency change was only to show, that with the
> depicted scenario the datepicker works with latest bootstrap and moment.
>
> Of course it would be nice to upgrade all deps to latest, but sao
> currently doesn't work with jquery3 (stops at login screen after succesful
> login) and the bugtracker of eonasdan-bootstrap-datetimepicker shows several
> open issues related to jquery3. So I don't think the upgrade to jquery3 won't
> be in the very near future?
>
Correctly if i'm wrong, but i think we only support jQuery2.
But we can upgrade bootstrap and moment.js to a newer version.> Sergi Almacellas Abellana <sergi@koolpi.com> added the comment:
>
> > Mathias Behrle <mbehrle@m9s.biz> added the comment:
> >
> >> BTW: have you found another bug which requires the upgrade?
> >
> > No. My motivation is just to provide a working datepicker via Debian
> > packages and testing showed, that neither 4.17.37 nor 4.17.42 worked in
> > sao.
>
> You should use the same dependencies.
:) That's not the way Debian (currently) works. As a package maintainer you
always try to get the latest release of a package into unstable/testing.
> >> Also with your proposed changes it will upgrade bootstrap and moment.js. So
> >> maybe al the dependencies should be upgraded.
> >
> > My intention with the dependency change was only to show, that with the
> > depicted scenario the datepicker works with latest bootstrap and moment.
> >
> > Of course it would be nice to upgrade all deps to latest, but sao
> > currently doesn't work with jquery3 (stops at login screen after succesful
> > login) and the bugtracker of eonasdan-bootstrap-datetimepicker shows several
> > open issues related to jquery3. So I don't think the upgrade to jquery3
> > won't be in the very near future?
> >
> Correctly if i'm wrong, but i think we only support jQuery2.
Yes, that's the current state. But jquery3 is just around the corner...;)
> But we can upgrade bootstrap and moment.js to a newer version.
Yes, this should be possible without problems.El 09/09/16 a les 16:57, Mathias Behrle ha escrit:
> Mathias Behrle <mbehrle@m9s.biz> added the comment:
>
>> > Sergi Almacellas Abellana <sergi@koolpi.com> added the comment:
>> >
>>> > > Mathias Behrle <mbehrle@m9s.biz> added the comment:
>>> > >
>>>> > >> BTW: have you found another bug which requires the upgrade?
>>> > >
>>> > > No. My motivation is just to provide a working datepicker via Debian
>>> > > packages and testing showed, that neither 4.17.37 nor 4.17.42 worked in
>>> > > sao.
>> >
>> > You should use the same dependencies.
> :) That's not the way Debian (currently) works. As a package maintainer you
> always try to get the latest release of a package into unstable/testing.
>
So to make sao compatible with debian, we must ensure that it works with
old version and newer versions. Am I right?
I'm uploading the attached patch as review33361002. I tested with the
current datetimepicker version and it works well. I think we can
introduce it to support newer versions.
This will allow to easly upgrade JS dependencies versions.* Sergi Almacellas Abellana: " [#5860 (closed)] Support of current
eonasdan-bootstrap-datetimepicker" (Mon, 12 Sep 2016 13:36:30 +0200):
> Sergi Almacellas Abellana <sergi@koolpi.com> added the comment:
>
> El 09/09/16 a les 16:57, Mathias Behrle ha escrit:
> > Mathias Behrle <mbehrle@m9s.biz> added the comment:
> >
> >> > Sergi Almacellas Abellana <sergi@koolpi.com> added the comment:
> >> >
> >>> > > Mathias Behrle <mbehrle@m9s.biz> added the comment:
> >>> > >
> >>>> > >> BTW: have you found another bug which requires the upgrade?
> >>> > >
> >>> > > No. My motivation is just to provide a working datepicker via Debian
> >>> > > packages and testing showed, that neither 4.17.37 nor 4.17.42 worked
> >>> > > in sao.
> >> >
> >> > You should use the same dependencies.
> > :) That's not the way Debian (currently) works. As a package maintainer you
> > always try to get the latest release of a package into unstable/testing.
> >
>
> So to make sao compatible with debian, we must ensure that it works with
> old version and newer versions. Am I right?
Yes.
> I'm uploading the attached patch as review33361002. I tested with the
> current datetimepicker version and it works well. I think we can
> introduce it to support newer versions.
Great.
> This will allow to easly upgrade JS dependencies versions.
At least most of them, yes.New changeset 07b6b0d53296 by Sergi Almacellas Abellana in branch 'default':
Update eonasdan-bootstrap-datetimepicker to latest stable version
http://hg.tryton.org/sao/rev/07b6b0d53296
